Page MenuHomePhabricator
Differential D10676

[native] Remove all instances of `LegacyThreadInfo` from `native`
ClosedPublic
Actions

Authored by atul on Jan 17 2024, 3:50 PM.
Tags
None
Referenced Files
F1799887: D10676.id36065.diff
Mon, May 20, 4:51 AM
F1799886: D10676.id35745.diff
Mon, May 20, 4:51 AM
F1799885: D10676.id36060.diff
Mon, May 20, 4:51 AM
F1799880: D10676.id36054.diff
Mon, May 20, 4:51 AM
F1799869: D10676.id.diff
Mon, May 20, 4:51 AM
F1799861: D10676.diff
Mon, May 20, 4:51 AM
Unknown Object (File)
Mar 5 2024, 1:37 PM
Unknown Object (File)
Mar 5 2024, 1:37 PM
View All 21 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM2d36c951d4b8: [native] Remove all instances of `LegacyThreadInfo` from `native`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

NOTE: Made a single change in lib to get this to pass CI.

Depends on D10675

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 17 2024, 3:50 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 17 2024, 3:50 PM
atul added reviewers: ashoat, ginsu, tomek.Jan 17 2024, 3:50 PM
atul published this revision for review.Jan 17 2024, 4:06 PM
Harbormaster completed remote builds in B25852: Diff 35745.Jan 17 2024, 4:09 PM
atul added a child revision: D10677: [lib] Remove most remaining instances of `LegacyThreadInfo` from `lib`.Jan 17 2024, 4:26 PM
tomek accepted this revision.Jan 18 2024, 3:01 AM
tomek added inline comments.
lib/shared/thread-utils.js
35–39 ↗(On Diff #35745)

Why the ordering of the imports was changed? We probably should revert this change.

This revision is now accepted and ready to land.Jan 18 2024, 3:01 AM
atul updated this revision to Diff 36054.Jan 23 2024, 1:00 PM

rebase

Harbormaster completed remote builds in B26090: Diff 36054.Jan 23 2024, 1:22 PM
atul updated this revision to Diff 36060.Jan 23 2024, 1:29 PM

remove extraneous import order changes

This revision was landed with ongoing or failed builds.Jan 23 2024, 1:43 PM
Closed by commit rCOMM2d36c951d4b8: [native] Remove all instances of `LegacyThreadInfo` from `native` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM2d36c951d4b8: [native] Remove all instances of `LegacyThreadInfo` from `native`.
Harbormaster completed remote builds in B26096: Diff 36060.Jan 23 2024, 1:49 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines
native/
avatars/
3 lines
7 lines
chat/
8 lines
3 lines
5 lines
3 lines
3 lines
3 lines
3 lines
3 lines
settings/
3 lines
3 lines
7 lines
3 lines
3 lines
3 lines
3 lines
3 lines
7 lines
7 lines
7 lines
3 lines
3 lines
3 lines
8 lines
7 lines
components/
3 lines
3 lines
invite-links/
3 lines
3 lines
keyboard/
9 lines
5 lines
markdown/
7 lines
media/
3 lines
navigation/
3 lines
3 lines
roles/
7 lines
5 lines
3 lines
3 lines
3 lines
user-profile/
3 lines
3 lines

Diff 36065

View Options

lib/shared/thread-utils.js

Loading...
View Options

native/avatars/edit-thread-avatar.react.js

Loading...
View Options

native/avatars/thread-avatar.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/fullscreen-thread-media-gallery.react.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/chat/inner-robotext-message.react.js

Loading...
View Options

native/chat/inner-text-message.react.js

Loading...
View Options

native/chat/message-list.react.js

Loading...
View Options

native/chat/message-preview.react.js

Loading...
View Options

native/chat/relationship-prompt.react.js

Loading...
View Options

native/chat/settings/add-users-modal.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...
View Options

native/chat/settings/thread-settings-color.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-edit-relationship.react.js

Loading...
View Options

native/chat/settings/thread-settings-home-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-member-tooltip-modal.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...
View Options

native/chat/settings/thread-settings-push-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-visibility.react.js

Loading...
View Options

native/chat/sidebar-list-modal.react.js

Loading...
View Options

native/chat/subchannels-list-modal.react.js

Loading...
View Options

native/components/community-actions-button.react.js

Loading...
View Options

native/components/thread-ancestors.react.js

Loading...
View Options

native/invite-links/manage-public-link-screen.react.js

Loading...
View Options

native/invite-links/view-invite-links-screen.react.js

Loading...
View Options

native/keyboard/keyboard-state-container.react.js

Loading...
View Options

native/keyboard/keyboard-state.js

Loading...
View Options

native/markdown/rules.react.js

Loading...
View Options

native/media/media-gallery-keyboard.react.js

Loading...
View Options

native/navigation/nav-selectors.js

Loading...
View Options

native/navigation/subchannels-button.react.js

Loading...
View Options

native/roles/change-roles-screen.react.js

Loading...
View Options

native/roles/community-roles-screen.react.js

Loading...
View Options

native/roles/create-roles-screen.react.js

Loading...
View Options

native/roles/role-panel-entry.react.js

Loading...
View Options

native/roles/role-utils.react.js

Loading...
View Options

native/user-profile/user-profile-menu-button.react.js

Loading...
View Options

native/user-profile/user-profile-relationship-button.react.js

Loading...