Page MenuHomePhabricator

Remove branching on `.minimallyEncoded` where no longer relevant
ClosedPublic

Authored by atul on Jan 24 2024, 10:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 9:45 PM
Unknown Object (File)
Tue, Oct 15, 10:07 PM
Unknown Object (File)
Tue, Oct 15, 10:07 PM
Unknown Object (File)
Tue, Oct 15, 10:07 PM
Unknown Object (File)
Tue, Oct 15, 10:06 PM
Unknown Object (File)
Tue, Oct 15, 10:06 PM
Unknown Object (File)
Tue, Oct 15, 10:06 PM
Unknown Object (File)
Sep 22 2024, 12:40 PM
Subscribers
None

Details

Summary

Remove branching on minimallyEncoded where no longer relevant.


Depends on D10807

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Jan 24 2024, 10:38 PM
tomek added inline comments.
lib/shared/thread-utils.js
1380–1381 ↗(On Diff #36123)

Just to make sure: can we assume that the defaultRole is always minimally-encoded?

1666–1668 ↗(On Diff #36123)

The same here: can we assume the encoding?

This revision is now accepted and ready to land.Jan 25 2024, 2:56 AM

Can you remove the extra newlines before landing? I'm assuming they're not intentional

Can you remove the extra newlines before landing? I'm assuming they're not intentional

Yeah my bad, really need to figure out my editor config after the ESLint/Prettier/etc bump to avoid all the noise that’s getting added. I’ll just turn it all off for now.

lib/shared/thread-utils.js
1380–1381 ↗(On Diff #36123)

Yeah, all the fields within a MinimallyEncodedThreadInfo should definitely be minimally encoded.