Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/shared/thread-utils.js | ||
---|---|---|
1380–1381 ↗ | (On Diff #36123) | Just to make sure: can we assume that the defaultRole is always minimally-encoded? |
1666–1668 ↗ | (On Diff #36123) | The same here: can we assume the encoding? |
Comment Actions
Can you remove the extra newlines before landing? I'm assuming they're not intentional
Comment Actions
Yeah my bad, really need to figure out my editor config after the ESLint/Prettier/etc bump to avoid all the noise that’s getting added. I’ll just turn it all off for now.
lib/shared/thread-utils.js | ||
---|---|---|
1380–1381 ↗ | (On Diff #36123) | Yeah, all the fields within a MinimallyEncodedThreadInfo should definitely be minimally encoded. |