Page MenuHomePhabricator
Differential D10731

[lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`
ClosedPublic
Actions

Authored by atul on Jan 18 2024, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 12:51 PM
Unknown Object (File)
Mar 11 2025, 4:09 PM
Unknown Object (File)
Mar 11 2025, 4:06 PM
Unknown Object (File)
Feb 21 2025, 9:25 PM
Unknown Object (File)
Feb 21 2025, 9:25 PM
Unknown Object (File)
Feb 21 2025, 9:25 PM
Unknown Object (File)
Feb 21 2025, 9:25 PM
Unknown Object (File)
Feb 21 2025, 9:25 PM
View All Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Commits
rCOMM4a14f1cb044c: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`
Summary

Part of https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Depends on D10730

Test Plan

flow, done automatically with IDE "Inline alias.." refactor

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Jan 18 2024, 2:10 PM
atul added a child revision: D10733: [lib] Remove `LegacyRoleInfo` where possible in `lib`.Jan 18 2024, 2:14 PM
Harbormaster completed remote builds in B25934: Diff 35856.Jan 18 2024, 2:28 PM
atul requested review of this revision.Jan 18 2024, 2:28 PM
ashoat accepted this revision.Jan 21 2024, 9:51 PM
ashoat added inline comments.
lib/shared/thread-utils.js
64 ↗(On Diff #35856)

Please revert import ordering changes before landing

This revision is now accepted and ready to land.Jan 21 2024, 9:51 PM
atul updated this revision to Diff 36080.Jan 23 2024, 2:37 PM

rebase

Harbormaster completed remote builds in B26109: Diff 36080.Jan 23 2024, 3:06 PM
atul updated this revision to Diff 36302.Jan 29 2024, 1:00 PM

rebase

atul updated this revision to Diff 36310.Jan 29 2024, 1:06 PM

fix import

Harbormaster completed remote builds in B26269: Diff 36302.Jan 29 2024, 1:19 PM
Harbormaster completed remote builds in B26277: Diff 36310.Jan 29 2024, 1:35 PM
Closed by commit rCOMM4a14f1cb044c: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo` (authored by atul). · Explain WhyJan 29 2024, 3:09 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM4a14f1cb044c: [lib] Expand `RoleInfo` to `LegacyRoleInfo | MinimallyEncodedRoleInfo`.

Revision Contents
Changeset List

PathSize
lib/
shared/
6 lines
types/
3 lines
utils/
10 lines

Diff 36318

View Options

lib/shared/thread-utils.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/types/thread-types.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines
View Options

lib/utils/role-utils.js

Show All 31 Lines
} from '../../navigation/route-names.js'; } from '../../navigation/route-names.js';
import { useStyles } from '../../themes/colors.js'; import { useStyles } from '../../themes/colors.js';
export type AvatarSelectionParams = { export type AvatarSelectionParams = {
+userSelections: { +userSelections: {
+coolOrNerdMode: CoolOrNerdMode, +coolOrNerdMode: CoolOrNerdMode,
+keyserverURL: string, +keyserverURL: string,
+accountSelection: AccountSelection, +accountSelection: AccountSelection,
+farcasterID: ?string,
}, },
}; };
type Props = { type Props = {
+navigation: RegistrationNavigationProp<'AvatarSelection'>, +navigation: RegistrationNavigationProp<'AvatarSelection'>,
+route: NavigationRoute<'AvatarSelection'>, +route: NavigationRoute<'AvatarSelection'>,
}; };
function AvatarSelection(props: Props): React.Node { function AvatarSelection(props: Props): React.Node {
▲ Show 20 Lines • Show All 157 Lines • Show Last 20 Lines