Page MenuHomePhabricator

[lib] Narrow `LogIn[Response/Result]` to `MinimallyEncodedRawThreadInfos`
ClosedPublic

Authored by atul on Jan 11 2024, 8:54 AM.
Tags
None
Referenced Files
F5332121: D10606.id35550.diff
Tue, Apr 8, 10:00 PM
F5329244: D10606.id35540.diff
Tue, Apr 8, 9:03 PM
F5329111: D10606.id35588.diff
Tue, Apr 8, 9:01 PM
F5326676: D10606.id35589.diff
Tue, Apr 8, 8:31 PM
Unknown Object (File)
Sun, Apr 6, 8:30 AM
Unknown Object (File)
Mar 8 2025, 5:04 AM
Unknown Object (File)
Mar 2 2025, 10:53 AM
Unknown Object (File)
Feb 22 2025, 2:36 AM
Subscribers
None

Details

Summary

Followup to D10588. This is the first step in removing the invariant inside the

action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === registerActionTypes.success ||
action.type === fullStateSyncActionType

condition.


Depends on D10588

Test Plan

N/A, trusting flow

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D10606 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2024, 9:10 AM
Harbormaster failed remote builds in B25700: Diff 35540!

separate out ClientLogInResponse and ServerLogInResponse to address flow issue in keyserver (not sure why it didn't get caught pre-commit)

atul published this revision for review.Jan 11 2024, 9:44 AM
ashoat added inline comments.
lib/types/account-types.js
158–161 ↗(On Diff #35550)

We should make sure cookieChange is read-only

Note: the + shorthand will not work here because of the type spread operator

This revision is now accepted and ready to land.Jan 11 2024, 9:49 AM

make cookieChange readonly