Paths

Table of Contentst

Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Authored by atul on Jan 15 2024, 12:40 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM4b48e731c0a1: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`

Summary

Part of the work described here: https://linear.app/comm/issue/ENG-6366/rename-minimallyencodedrawthreadinfo-to-rawthreadinfo

Used IDE "Inline type alias" feature to do this refactor automatically. Read through to make sure there were no issues. Had to insert ? manually for MinimallyEncodedThreadInfo where it was previously ?ThreadInfo.

Depends on D10638

Test Plan

flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 15 2024, 12:40 PM

NOTE: Still need to make some tweaks to thread-utils and thread-selectors before removing ThreadInfo altogether. Will be handled in followup diff.

atul added a child revision: D10640: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-selectors`.Jan 15 2024, 12:57 PM

Harbormaster completed remote builds in B25778: Diff 35641.Jan 15 2024, 1:01 PM

atul requested review of this revision.Jan 15 2024, 1:01 PM

atul mentioned this in D10641: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in `thread-utils`.Jan 15 2024, 1:11 PM

This is going to add a lot of noise to the codebase... what % of these unions do you think you'll be able to "back out" back to just the minimally-encoded variant?

web/types/nav-types.js
1 ↗	(On Diff #35641)	Interesting that this file got random ESLint/Prettier changes

This revision is now accepted and ready to land.Jan 15 2024, 5:41 PM

rebase

In D10639#307856, @ashoat wrote:

This is going to add a lot of noise to the codebase... what % of these unions do you think you'll be able to "back out" back to just the minimally-encoded variant?

In practice it ended up being ~75+%. They're pretty much fully removed from web/native client except to support old migrations.

Unless you're talking about git history noise vs the noise of having multiple types around?

web/types/nav-types.js
1 ↗	(On Diff #35641)	Looks like we also should have a newline after @flow, will update this diff.

add newline after @flow

This revision was landed with ongoing or failed builds.Jan 22 2024, 12:36 PM

Closed by commit rCOMM4b48e731c0a1: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul mentioned this in rCOMMaadf73d8ac7d: [lib] Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo` in….

atul added a commit: rCOMM4b48e731c0a1: Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`.

Harbormaster completed remote builds in B26049: Diff 35992.Jan 22 2024, 12:38 PM

Harbormaster completed remote builds in B26054: Diff 35997.Jan 22 2024, 12:45 PM

Large Diff

This large diff affects 202 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

34 lines

lib/

components/

chat-mention-provider.react.js

11 lines

hooks/

chat-mention-hooks.js

5 lines

child-threads.js

19 lines

promote-sidebar.react.js

16 lines

relationship-prompt.js

5 lines

search-threads.js

18 lines

toggle-unread-status.js

7 lines

selectors/

chat-selectors.js

94 lines

nav-selectors.js

14 lines

shared/

ancestor-threads.js

9 lines

avatar-utils.js

28 lines

edit-messages-utils.js

11 lines

inline-engagement-utils.js

7 lines

mention-utils.js

9 lines

message-utils.js

44 lines

messages/

add-members-message-spec.js

9 lines

change-role-message-spec.js

15 lines

change-settings-message-spec.js

13 lines

create-entry-message-spec.js

11 lines

create-sidebar-message-spec.js

11 lines

create-sub-thread-message-spec.js

13 lines

create-thread-message-spec.js

11 lines

delete-entry-message-spec.js

11 lines

edit-entry-message-spec.js

11 lines

join-thread-message-spec.js

9 lines

leave-thread-message-spec.js

9 lines

message-spec.js

21 lines

multimedia-message-spec.js

23 lines

reaction-message-spec.js

15 lines

remove-members-message-spec.js

11 lines

restore-entry-message-spec.js

13 lines

text-message-spec.js

21 lines

update-relationship-message-spec.js

13 lines

25 lines

7 lines

21 lines

16 lines

types/

messages/

create-sidebar.js

5 lines

create-subthread.js

5 lines

create-thread.js

9 lines

utils/

drawer-utils.react.js

27 lines

entity-helpers.js

22 lines

entity-text.js

24 lines

message-pinning-utils.js

18 lines

role-utils.js

7 lines

native/

avatars/

edit-thread-avatar.react.js

9 lines

thread-avatar.react.js

16 lines

calendar/

calendar.react.js

43 lines

entry.react.js

34 lines

chat/

chat-context-provider.react.js

11 lines

chat-context.js

5 lines

chat-input-bar.react.js

67 lines

chat-router.js

37 lines

chat-thread-list-item.react.js

13 lines

chat-thread-list-see-more-sidebars.react.js

7 lines

chat-thread-list-sidebar.react.js

13 lines

chat-thread-list.react.js

35 lines

compose-subchannel.react.js

25 lines

failed-send.react.js

7 lines

fullscreen-thread-media-gallery.react.js

7 lines

image-paste-modal.react.js

7 lines

inline-engagement.react.js

19 lines

inner-robotext-message.react.js

9 lines

inner-text-message.react.js

9 lines

message-list-container.react.js

13 lines

message-list-header-title.react.js

5 lines

message-list-types.js

13 lines

message-list.react.js

19 lines

message-preview.react.js

5 lines

message-result.react.js

5 lines

message-results-screen.react.js

7 lines

parent-thread-header.react.js

7 lines

relationship-prompt.react.js

5 lines

settings/

add-users-modal.react.js

9 lines

color-selector-modal.react.js

9 lines

compose-subchannel-modal.react.js

7 lines

delete-thread.react.js

19 lines

emoji-thread-avatar-creation.react.js

9 lines

thread-settings-child-thread.react.js

7 lines

thread-settings-color.react.js

7 lines

thread-settings-description.react.js

15 lines

thread-settings-edit-relationship.react.js

7 lines

thread-settings-home-notifs.react.js

9 lines

thread-settings-leave-thread.react.js

14 lines

thread-settings-member-tooltip-modal.react.js

12 lines

thread-settings-member.react.js

18 lines

thread-settings-parent.react.js

9 lines

thread-settings-promote-sidebar.react.js

7 lines

thread-settings-push-notifs.react.js

9 lines

thread-settings-visibility.react.js

7 lines

thread-settings.react.js

52 lines

sidebar-list-modal.react.js

15 lines

sidebar-navigation.js

7 lines

subchannels-list-modal.react.js

15 lines

swipeable-thread.react.js

10 lines

thread-list-modal.react.js

15 lines

thread-settings-button.react.js

5 lines

thread-settings-header-title.react.js

5 lines

toggle-pin-modal.react.js

7 lines

utils.js

7 lines

components/

community-actions-button.react.js

9 lines

community-pill.react.js

7 lines

thread-ancestors-label.react.js

5 lines

thread-ancestors.react.js

11 lines

thread-list-thread.react.js

12 lines

thread-list.react.js

65 lines

thread-pill.react.js

5 lines

input/

input-state-container.react.js

92 lines

input-state.js

17 lines

invite-links/

manage-public-link-screen.react.js

5 lines

view-invite-links-screen.react.js

7 lines

keyboard/

keyboard-input-host.react.js

7 lines

keyboard-state-container.react.js

15 lines

keyboard-state.js

9 lines

markdown/

rules.react.js

7 lines

media/

chat-camera-modal.react.js

5 lines

media-gallery-keyboard.react.js

11 lines

navigation/

nav-selectors.js

23 lines

subchannels-button.react.js

7 lines

push/

push-handler.react.js

36 lines

roles/

change-roles-screen.react.js

10 lines

community-roles-screen.react.js

12 lines

create-roles-screen.react.js

9 lines

role-panel-entry.react.js

7 lines

role-utils.react.js

7 lines

search/

message-search.react.js

7 lines

search-messages-button.react.js

5 lines

selectors/

calendar-selectors.js

9 lines

types/

chat-types.js

15 lines

user-profile/

user-profile-menu-button.react.js

7 lines

user-profile-message-button.react.js

5 lines

user-profile-relationship-button.react.js

7 lines

utils/

drawer-utils.react.js

5 lines

web/

avatars/

edit-thread-avatar-menu.react.js

9 lines

edit-thread-avatar.react.js

9 lines

thread-avatar.react.js

9 lines

thread-emoji-avatar-selection-modal.react.js

9 lines

calendar/

day.react.js

11 lines

chat/

chat-input-bar.react.js

23 lines

chat-message-list.react.js

19 lines

chat-thread-list-item-menu.react.js

5 lines

chat-thread-list-see-more-sidebars.react.js

5 lines

composed-message.react.js

7 lines

edit-message-provider.js

5 lines

edit-text-message.react.js

5 lines

failed-send.react.js

9 lines

inline-engagement.react.js

7 lines

message-preview.react.js

5 lines

message.react.js

5 lines

multimedia-message.react.js

6 lines

pinned-messages-banner.react.js

5 lines

relationship-prompt/

relationship-prompt.js

5 lines

robotext-message.react.js

7 lines

text-message.react.js

5 lines

thread-menu.react.js

9 lines

thread-top-bar.react.js

5 lines

components/

message-result.react.js

5 lines

input/

input-state-container.react.js

94 lines

input-state.js

20 lines

invite-links/

manage/

edit-link-modal.react.js

5 lines

markdown/

rules.react.js

5 lines

modals/

chat/

pinned-messages-modal.react.js

7 lines

sidebar-promote-modal.react.js

5 lines

toggle-pin-modal.react.js

7 lines

search/

message-search-modal.react.js

5 lines

message-search-utils.react.js

11 lines

threads/

confirm-leave-thread-modal.react.js

5 lines

create/

compose-subchannel-modal.react.js

9 lines

steps/

subchannel-members-list.react.js

10 lines

subchannel-members.react.js

5 lines

gallery/

thread-settings-media-gallery.react.js

5 lines

members/

change-member-role-modal.react.js

10 lines

member.react.js

10 lines

members-list.react.js

5 lines

settings/

thread-settings-delete-confirmation-modal.react.js

5 lines

thread-settings-delete-tab.react.js

5 lines

thread-settings-general-tab.react.js

8 lines

thread-settings-modal.react.js

17 lines

thread-settings-privacy-tab.react.js

10 lines

thread-picker-modal.react.js

5 lines

user-profile/

user-profile-action-buttons.react.js

5 lines

user-profile-menu.react.js

5 lines

user-profile-message-button.react.js

5 lines

navigation-panels/

chat-thread-ancestors.react.js

5 lines

nav-state-info-bar.react.js

7 lines

roles/

community-roles-modal.react.js

14 lines

create-roles-modal.react.js

7 lines

delete-role-modal.react.js

7 lines

role-actions-menu.react.js

5 lines

role-panel-entry.react.js

5 lines

selectors/

calendar-selectors.js

7 lines

chat-selectors.js

19 lines

thread-selectors.js

10 lines

sidebar/

community-drawer-item-community-handlers.react.js

7 lines

community-drawer-item-handlers.react.js

5 lines

community-drawer-utils.react.js

5 lines

subchannels-button.react.js

5 lines

tooltips/

message-tooltip.react.js

9 lines

tooltip-action-utils.js

25 lines

types/

nav-types.js

12 lines

utils/

thread-utils.js

5 lines

Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`ClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 35997

keyserver/src/push/send.js

lib/components/chat-mention-provider.react.js

lib/hooks/chat-mention-hooks.js

lib/hooks/child-threads.js

lib/hooks/promote-sidebar.react.js

lib/hooks/relationship-prompt.js

lib/hooks/search-threads.js

lib/hooks/toggle-unread-status.js

lib/selectors/chat-selectors.js

lib/selectors/nav-selectors.js

lib/shared/ancestor-threads.js

lib/shared/avatar-utils.js

lib/shared/edit-messages-utils.js

lib/shared/inline-engagement-utils.js

lib/shared/mention-utils.js

lib/shared/message-utils.js

lib/shared/messages/add-members-message-spec.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/remove-members-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

lib/shared/notif-utils.js

lib/shared/reaction-utils.js

lib/shared/search-utils.js

lib/shared/user-utils.js

lib/types/messages/create-sidebar.js

lib/types/messages/create-subthread.js

lib/types/messages/create-thread.js

lib/utils/drawer-utils.react.js

lib/utils/entity-helpers.js

lib/utils/entity-text.js

lib/utils/message-pinning-utils.js

lib/utils/role-utils.js

native/avatars/edit-thread-avatar.react.js

native/avatars/thread-avatar.react.js

native/calendar/calendar.react.js

native/calendar/entry.react.js

native/chat/chat-context-provider.react.js

native/chat/chat-context.js

native/chat/chat-input-bar.react.js

native/chat/chat-router.js

native/chat/chat-thread-list-item.react.js

native/chat/chat-thread-list-see-more-sidebars.react.js

native/chat/chat-thread-list-sidebar.react.js

native/chat/chat-thread-list.react.js

native/chat/compose-subchannel.react.js

native/chat/failed-send.react.js

native/chat/fullscreen-thread-media-gallery.react.js

native/chat/image-paste-modal.react.js

native/chat/inline-engagement.react.js

native/chat/inner-robotext-message.react.js

native/chat/inner-text-message.react.js

native/chat/message-list-container.react.js

native/chat/message-list-header-title.react.js

native/chat/message-list-types.js

native/chat/message-list.react.js

native/chat/message-preview.react.js

native/chat/message-result.react.js

native/chat/message-results-screen.react.js

native/chat/parent-thread-header.react.js

Expand `ThreadInfo` to `LegacyThreadInfo | MinimallyEncodedThreadInfo`
ClosedPublic
Actions

Revision Contents
Changeset List