Page MenuHomePhabricator

[lib] Remove `LegacyThreadInfo`-related type utilities
ClosedPublic

Authored by atul on Jan 18 2024, 11:52 AM.
Tags
None
Referenced Files
F3390296: D10720.diff
Fri, Nov 29, 11:12 PM
Unknown Object (File)
Tue, Nov 26, 6:42 PM
Unknown Object (File)
Thu, Nov 7, 4:33 AM
Unknown Object (File)
Oct 30 2024, 5:54 AM
Unknown Object (File)
Oct 30 2024, 5:18 AM
Unknown Object (File)
Oct 23 2024, 4:27 AM
Unknown Object (File)
Oct 23 2024, 4:19 AM
Unknown Object (File)
Oct 21 2024, 2:29 AM
Subscribers
None

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Jan 18 2024, 12:29 PM
ashoat added inline comments.
lib/types/minimally-encoded-thread-permissions-types.js
12 ↗(On Diff #35841)

Can you revert import ordering changes before landing?

This revision is now accepted and ready to land.Jan 21 2024, 9:34 PM
This revision was landed with ongoing or failed builds.Jan 26 2024, 4:48 PM
This revision was automatically updated to reflect the committed changes.

Import ordering changes don't appear to have been reverted, but at this point it won't help to revert it since we'd need a separate commit

Dang rebased off of the wrong branch for this (everything is correct except import ordering). Will double check rest of stack to make sure diffs are updated properly.