Page MenuHomePhabricator
Feed Advanced Search

Jul 17 2024

will closed D12777: [nix] Replaces brew install of watchman with nix.
Jul 17 2024, 6:13 AM
will committed rCOMM30b605adaa15: [nix] Replaces brew install of watchman with nix (authored by will).
[nix] Replaces brew install of watchman with nix
Jul 17 2024, 6:13 AM

Jul 16 2024

will updated the diff for D12777: [nix] Replaces brew install of watchman with nix.

feedback. remove unnecessary homebrew install deps script

Jul 16 2024, 8:01 PM
will updated the diff for D12710: [terraform] add authoritative keyserver id as a user-specified variable.

review feedback

Jul 16 2024, 7:54 PM
will updated the diff for D12711: [terraform] Introduce secondary keyserver service.

rebase

Jul 16 2024, 3:01 PM
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.

only create vpc, subnets, and internet gateway if user created option is true

Jul 16 2024, 3:00 PM
will updated the diff for D12708: [keyserver] configure separation of primary secondary logic.

feedback

Jul 16 2024, 2:19 PM
will updated the diff for D12708: [keyserver] configure separation of primary secondary logic.

reduce line count

Jul 16 2024, 2:03 PM
will updated the summary of D12731: [terraform] Migration script for for self-hosted keyserver.
Jul 16 2024, 2:00 PM
will updated the diff for D12731: [terraform] Migration script for for self-hosted keyserver.

include logic to disable traffic until all nodes available

Jul 16 2024, 2:00 PM
will added inline comments to D12777: [nix] Replaces brew install of watchman with nix.
Jul 16 2024, 12:12 PM
will updated the diff for D12711: [terraform] Introduce secondary keyserver service.

create secondary resources after primary

Jul 16 2024, 11:39 AM
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.

typo

Jul 16 2024, 11:35 AM
will updated the diff for D12560: [terraform] set up keyserver load balancer.

include security group

Jul 16 2024, 11:33 AM
will updated the test plan for D12777: [nix] Replaces brew install of watchman with nix.
Jul 16 2024, 7:54 AM
will requested review of D12777: [nix] Replaces brew install of watchman with nix.
Jul 16 2024, 7:48 AM

Jul 12 2024

will updated the summary of D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Jul 12 2024, 11:12 AM
will abandoned D12528: [terraform] run mariadb in public db group.

No longer needed. Included in prior diff

Jul 12 2024, 11:10 AM
will updated the diff for D12339: [terraform] Use default vpc, subnets, and internet gateway for self-host.

Add option for user created vpc to avoid migration of prod aws rds instance to new vpc

Jul 12 2024, 10:26 AM
will accepted D12719: Fix CORS issues with identity HTTP.

Looks good!

Jul 12 2024, 8:01 AM

Jul 11 2024

will updated the summary of D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.
Jul 11 2024, 2:39 PM
will planned changes to D12731: [terraform] Migration script for for self-hosted keyserver.
Jul 11 2024, 1:44 PM
will planned changes to D12710: [terraform] add authoritative keyserver id as a user-specified variable.
Jul 11 2024, 12:32 PM
will updated the test plan for D12731: [terraform] Migration script for for self-hosted keyserver.
Jul 11 2024, 12:08 PM
will requested review of D12731: [terraform] Migration script for for self-hosted keyserver.
Jul 11 2024, 12:07 PM
will accepted D12723: [terraform] bump staging identity to 0.29-staging.
Jul 11 2024, 11:08 AM
will requested review of D12730: [terraform] Ensure that the primary service is running before deploying secondary service.
Jul 11 2024, 10:28 AM
will requested review of D12729: [terraform] Make number of secondary nodes configured by the user.
Jul 11 2024, 10:24 AM
will added inline comments to D12689: [terraform] create comm database on aws rds startup.
Jul 11 2024, 8:32 AM
will requested review of D12725: [terraform] add Tunnelbroker configuration variable to self-host.
Jul 11 2024, 4:48 AM
will requested review of D12724: [keyserver] add `aws` proxy type for self-hosted keyservers.
Jul 11 2024, 4:36 AM
will requested changes to D12723: [terraform] bump staging identity to 0.29-staging.

Just saw https://linear.app/comm/issue/ENG-8810/unable-to-login#comment-47abbe95. Unrelated to the actual code in this diff but we should probably make a fix a dependency for this one

Jul 11 2024, 4:10 AM
will accepted D12723: [terraform] bump staging identity to 0.29-staging.
Jul 11 2024, 4:04 AM

Jul 10 2024

will updated the diff for D12689: [terraform] create comm database on aws rds startup.

run this command every time

Jul 10 2024, 2:25 PM
will accepted D12704: [identity] fix issues with capitalized usernames in users and reserved usernames tables.

Directly synced with Varun. Looks good. Before landing make sure to remove need for unnecessary partition key check and add a comment for changes starting from line 340 in services/identity/src/database.rs

Jul 10 2024, 9:35 AM
will added inline comments to D12719: Fix CORS issues with identity HTTP.
Jul 10 2024, 7:41 AM

Jul 9 2024

will requested review of D12711: [terraform] Introduce secondary keyserver service.
Jul 9 2024, 7:47 PM
will requested review of D12709: [terraform] Ensure only one running ecs task for primary service.
Jul 9 2024, 7:45 PM
will requested review of D12710: [terraform] add authoritative keyserver id as a user-specified variable.
Jul 9 2024, 7:45 PM
will requested review of D12708: [keyserver] configure separation of primary secondary logic.
Jul 9 2024, 7:39 PM
will requested review of D12689: [terraform] create comm database on aws rds startup.
Jul 9 2024, 6:56 AM

Jul 8 2024

will requested review of D12691: [terraform] include REDIS_URL as part of keyserver terraform config.
Jul 8 2024, 6:03 AM
will requested review of D12690: [terraform] restrict redis access to ecs keyserver service only.
Jul 8 2024, 5:56 AM
will requested review of D12688: [terraform] make aws rds instance class configurable for self-hosting.
Jul 8 2024, 5:50 AM
will requested review of D12687: [keyserver] use yarn instead of npm for running prod.
Jul 8 2024, 5:47 AM
will requested review of D12686: [lib] remove integrity store assertion and use sqlite.
Jul 8 2024, 5:30 AM
will updated the diff for D12531: [terraform] initial ecs setup for keyserver primary.

set to false initially

Jul 8 2024, 3:35 AM

Jun 28 2024

will requested review of D12623: [identity] downgrade no auth message error to warning.
Jun 28 2024, 4:41 PM
will closed D12622: [terraform] upgrade identity staging image to 0.27-staging.
Jun 28 2024, 3:27 PM
will committed rCOMMe5da765b7617: [terraform] upgrade identity staging image to 0.27-staging (authored by will).
[terraform] upgrade identity staging image to 0.27-staging
Jun 28 2024, 3:27 PM
will closed D12621: [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 3:27 PM
will committed rCOMM41b1598dab24: [identity] ensure identity reqwest crate has rustls-tls (authored by will).
[identity] ensure identity reqwest crate has rustls-tls
Jun 28 2024, 3:27 PM
will updated the test plan for D12621: [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 3:19 PM
will updated the test plan for D12622: [terraform] upgrade identity staging image to 0.27-staging.
Jun 28 2024, 3:18 PM
will updated the diff for D12622: [terraform] upgrade identity staging image to 0.27-staging.

rebase

Jun 28 2024, 3:09 PM
will updated the diff for D12622: [terraform] upgrade identity staging image to 0.27-staging.

rebase with new docker image push

Jun 28 2024, 3:04 PM
will retitled D12621: [identity] ensure identity reqwest crate has rustls-tls from [services] add back default features to reqwest in cargo workspaces to [identity] ensure identity reqwest crate has rustls-tls.
Jun 28 2024, 2:58 PM
will updated the diff for D12621: [identity] ensure identity reqwest crate has rustls-tls.

revamp. No longer reenabling default features. Instead just adding to rustls-tls to identity Cargo.toml

Jun 28 2024, 2:57 PM
will published D12622: [terraform] upgrade identity staging image to 0.27-staging for review.
Jun 28 2024, 1:43 PM
will updated the diff for D12621: [identity] ensure identity reqwest crate has rustls-tls.

recompile backup_client from workspace cargo.toml change

Jun 28 2024, 1:32 PM
will published D12621: [identity] ensure identity reqwest crate has rustls-tls for review.
Jun 28 2024, 1:01 PM

Jun 27 2024

will closed D12579: [terraform] service connection error alarms.
Jun 27 2024, 10:06 AM
will committed rCOMMc467ef6439c5: [terraform] service connection error alarms (authored by will).
[terraform] service connection error alarms
Jun 27 2024, 10:06 AM

Jun 26 2024

will updated the diff for D12579: [terraform] service connection error alarms.

add email subscription

Jun 26 2024, 3:16 PM
will closed D12564: [terraform] created combined error reports email.
Jun 26 2024, 3:05 PM
will committed rCOMM6704a4e7c9de: [terraform] created combined error reports email (authored by will).
[terraform] created combined error reports email
Jun 26 2024, 3:05 PM
will closed D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 26 2024, 3:05 PM
will committed rCOMM5c7fad19c1ab: [terraform] change cloudwatch subscription prefix from common to identity (authored by will).
[terraform] change cloudwatch subscription prefix from common to identity
Jun 26 2024, 3:05 PM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 3:00 PM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 3:00 PM
will updated the diff for D12579: [terraform] service connection error alarms.

fix filters and log group names

Jun 26 2024, 2:58 PM
will updated the summary of D12579: [terraform] service connection error alarms.
Jun 26 2024, 9:18 AM
will updated the test plan for D12579: [terraform] service connection error alarms.
Jun 26 2024, 9:18 AM
will updated the diff for D12579: [terraform] service connection error alarms.

change pattern to "dns error"

Jun 26 2024, 9:17 AM
will planned changes to D12579: [terraform] service connection error alarms.

We actually do want this as "dns error"

Jun 26 2024, 8:45 AM
will requested review of D12579: [terraform] service connection error alarms.
Jun 26 2024, 7:53 AM

Jun 25 2024

will updated the summary of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 25 2024, 10:21 AM
will updated the summary of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 25 2024, 10:20 AM
will added a comment to D12563: [terraform] change cloudwatch subscription prefix from common to identity.

Are you planning to use moved { } block? Or use terraform state mv to move it without recreating?

Jun 25 2024, 10:20 AM

Jun 24 2024

will requested review of D12564: [terraform] created combined error reports email.
Jun 24 2024, 10:01 PM
will requested review of D12563: [terraform] change cloudwatch subscription prefix from common to identity.
Jun 24 2024, 10:00 PM
will requested review of D12560: [terraform] set up keyserver load balancer.
Jun 24 2024, 7:50 PM
will requested review of D12559: [terraform] Increase keyserver primary ecs task resources.
Jun 24 2024, 7:46 PM
will added inline comments to D12531: [terraform] initial ecs setup for keyserver primary.
Jun 24 2024, 7:26 PM
will updated the summary of D12558: [keyserver] add health check route to keyserver for use by load balancer.
Jun 24 2024, 7:25 PM
will requested review of D12558: [keyserver] add health check route to keyserver for use by load balancer.
Jun 24 2024, 6:56 PM
will published D12531: [terraform] initial ecs setup for keyserver primary for review.
Jun 24 2024, 6:42 PM
will accepted D12555: [terraform] bump staging identity to 0.26.
Jun 24 2024, 6:38 PM
will closed D12550: [terraform] Change alarm names to reflect staging or production environment.
Jun 24 2024, 10:18 AM
will committed rCOMMf6f382e7b6d9: [terraform] Change alarm names to reflect staging or production environment (authored by will).
[terraform] Change alarm names to reflect staging or production environment
Jun 24 2024, 10:18 AM
will closed D12551: [identity] Downgrades search trace error.
Jun 24 2024, 10:17 AM
will committed rCOMM94236c7f1b9a: [identity] Downgrades search trace error (authored by will).
[identity] Downgrades search trace error
Jun 24 2024, 10:17 AM

Jun 23 2024

will requested review of D12551: [identity] Downgrades search trace error.
Jun 23 2024, 8:41 PM
will requested review of D12550: [terraform] Change alarm names to reflect staging or production environment.
Jun 23 2024, 8:22 PM

Jun 20 2024

will requested review of D12529: [terraform] Allow all ip addresses to access self-host internet gateway.
Jun 20 2024, 8:30 PM
will requested review of D12528: [terraform] run mariadb in public db group.
Jun 20 2024, 8:28 PM
will accepted D12515: [identity] fix wallet account deletion bug.
Jun 20 2024, 1:18 PM

Jun 19 2024

will requested review of D12475: [keyserver] upgrade redis to version 7 on docker based keyserver.
Jun 19 2024, 10:32 AM

Jun 18 2024

will added a comment to D12457: [terraform] Upgrade AWS Terraform provider to 5.32.0.

Why not the latest version?

Jun 18 2024, 10:00 AM
will accepted D12447: [identity][websocket] Call DB client directly to verify CSAT.

This makes a lot of sense. Not sure why I didn't consider this on first implementation but glad you caught it now.

Jun 18 2024, 7:15 AM