Shouldn't D14391 be added to the stack here? You seem to be depending on it
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
Feb 28 2025
Feb 27 2025
In D14414#400524, @bartek wrote:An alternative approach, that doesn't require using temporary file:
- Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
- For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
- For non-encrypted, fetch base64 but don't save to file (skip last step)
- call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116
Should we bump the version in keyserver/src/session/version.js along with this change?
I'm not entirely sure what functionality I should be testing to verify that backup-client-wasm still works correctly on web. If reviewers have any context here, please feel free to test that functionality on https://comm.software/
Feb 26 2025
Looks great!
Feb 25 2025
Feedback
Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase
Avoid fetching latest message in reactionMessageSpec.getLastUpdatedTime until function is actually called
Feb 24 2025
Review
Just confirming – is this screen only used when the restore is in-progress? If the button to start is on this screen too, we might want to only prevent the user from navigating away after the button is pressed
Feb 22 2025
Feb 21 2025
Just leaving a note here that we should address this comment in this diff
Adding support for this would be complicated as there is no simple way of running a couple animations at once but consider that this is an animation after a double click. What other animation can be run while/after user double clicks the image? To double click user needs to stop doing anything for a moment and any animation will finish in the meantime.
Feb 20 2025
A lovely feeling to get to the end of the stack here. Great work on all of this, @angelika!!
I'd be surprised if this diff was the cause, as here we cancel animations at the start of a pan or pinch, but in the video we see an issue at the conclusion of a pan.
Feb 19 2025
The diff is titled [lib] but only seems to touch [native]. Wondering if we need something similar on the secondary device side (for both native / web), or if we already wait for the Tunnelbroker connection there (since we need to open a special "unauthorized" connection anyways)
Feb 18 2025
Can you share a screenshot of the order we end up seeing? Curious in what order the boosted communities will appear