- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Nov 7 2022
Rebasing on master changes.
Changing to use vec! macro.
Rebasing on parent changes.
Changing function name from initialization to initialize, based on the comment https://phab.comm.dev/D5432#162406.
Rebasing on parent changes.
Rebasing on parent changes.
In D5431#162401, @tomek wrote:This diff removes a lot of code. In the previous diff we added only a part of it. I assume in the next diffs most of this code will be reintroduced, but that makes it hard to verify if the code remains correct. It would be better if parts of the code were moved in a diff instead of removing in one and adding in another.
Rebasing on parent changes.
Nov 4 2022
Rebasing on the parent changes.
Changing the binary location directory to build instead of build/bin according to changes in D5430.
In D5430#163958, @jon wrote:the binary is in the build directory as well if I use just install(TARGETS runTests RUNTIME DESTINATION bin) which must use build/bin directory. But it's not and puts the binary into the build directory.
The INSTALL(TARGETS ...) cmake options only come into play when you do something like cmake .. && make install. Otherwise it doesn't do much.
Removing of the CMAKE_RUNTIME_OUTPUT_DIRECTORY.
Rebasing on parent changes.
Adding of debug message.
Adding variables cloning before the move into the spawned task.
Small changes based on comments.
Using of the shorthand of cxx_bridge calls. Using of the unwrap_or instead of matching.
Move cxx_bridge to the use super::cxx_bridge::ffi for shorter calls instead of the full path.
Nov 3 2022
Thanks for the clarification @tomek ;)
Seems that the Nix build error is unrelated to the last changes as the only comment was added here.
Adding a comment about the metadata.
In D5525#163498, @tomek wrote:The Linear task mentions that it is a good practice to use a comment to describe metadata - can we do that?
Nov 2 2022
Adding a comment for CMP0003 policy
Changing the SDK install and sources copying commands order.
Small changes addressing comments.
Oct 27 2022
Updating Tokio to 1.21 version.
Rebasing on a parent changes.
Fixing gRPC struct from grpcResult to idiomatic GrpcResult name.
Oct 26 2022
Oct 25 2022
Oct 24 2022
Cargo re-run if proto file was changed is added.
Adding to the Tunnelbroker to Rust transition stack.
Rebased on the Cargo stack changes.
In D5430#161065, @jon wrote:please also update the path used by the tunnel broker tests under .buildkite/
In D5428#161080, @jon wrote:The CI gates should be updated as part of this as well, having two failing gates isn't good.
I would also be fine with some additional diffs later in the stack which fix the builds later on, however, delaying being "green to green" also means that we will have a lot of intermediate diffs which fail to build or pass tests :(
Adding of the gTest building and running for the legacy C++ code.
Reducing the file size by squashing commands.
Adding of annotations.
Adding of the building and running of the gTest for the legacy C++ codebase.
Update on a stack changes.
Updating on a stack changes.
Update on a stack changes.
Update on the stack changes.