Is this ready for review, or are there changes planned? Sending to your queue, but feel free to re-request review

rebase before landing

rebase and land

capitalize AS everywhere

Linear task with followup: https://linear.app/comm/issue/ENG-3666/pull-common-image-avatar-construction-logic-out-of-user-fetchers

re-introduce invariant

update

This was originally split up in a much cleaner way.

rebase and alnd

rebase and land

Don’t have context

(Once you're done with your test plan make sure to update the db_version in metadata table back to what's in migration-config)

Okay so I was having trouble with Redux DevTools, so I tested by

Ok I'm confused, here's the diff from before and after: https://www.diffchecker.com/P9mWVrym/

include DESCENDANT_EDIT_THREAD_AVATAR

The goal of all of this work is to make sure the state check mechanism doesn't have to do any "fixing". When we rely on the state check mechanism, it leads to performance issues as somebody's entire ThreadStore has to be replaced.

rebase before addressing feedback

Eg. compile prod build that doesn't support avatar permission with old codeVersion, point it at local keyserver, run keyserver that optionally omits avatar permission – make sure state check mechanism is being called via redux-devtools (hopefully it works better for you than me), and that it isn't detecting any changes

address feedback so roles has permissions filtered out

rebase before addressing feedback

rebase and land

rebase before landing

Sorry... going to put 207 and 208 out today. There was an issue with the Android release so I need to kick it off again.

rebase and alnd

resolve merge conflict and land

address feedback

Would be great to test a MULTIMEDIA message with eg 1 video, 1 video + 1 image, 2 videos in addition to photos mentioned in Test Plan (if not done already)