Page MenuHomePhorge
Feed Search

Search
Use Results
Hide Query

Sep 22 2023

ginsu attached a referenced file: F770513: Screenshot 2023-09-22 at 4.34.33 PM.png.
Sep 22 2023, 8:36 PM
ginsu updated the summary of D9252: [lib/native] introduce UserProfileMessageButton.
Sep 22 2023, 8:35 PM
ginsu attached a referenced file: F770483: Screenshot 2023-09-22 at 4.25.11 PM.png.
Sep 22 2023, 8:33 PM
ginsu updated the summary of D9258: [native] introduce UserProfileRelationshipButton.
Sep 22 2023, 8:33 PM
ginsu attached a referenced file: F770478: Screenshot 2023-09-22 at 4.15.11 PM.png.
Sep 22 2023, 8:23 PM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Sep 22 2023, 8:23 PM
ginsu added inline comments to D9258: [native] introduce UserProfileRelationshipButton.
Sep 22 2023, 8:22 PM
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

rebase

Sep 22 2023, 8:17 PM
ginsu attached a referenced file: F770444: Screenshot 2023-09-22 at 4.15.11 PM.png.
Sep 22 2023, 8:16 PM
ginsu updated the test plan for D9252: [lib/native] introduce UserProfileMessageButton.
Sep 22 2023, 8:15 PM
ginsu added inline comments to D9252: [lib/native] introduce UserProfileMessageButton.
Sep 22 2023, 8:14 PM
ginsu updated the diff for D9252: [lib/native] introduce UserProfileMessageButton.

we should also not show message button if the user and/or viewer is blocked

Sep 22 2023, 8:12 PM
ginsu updated the diff for D9258: [native] introduce UserProfileRelationshipButton.

fix icon

Sep 22 2023, 3:43 AM

Sep 21 2023

ginsu closed D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 21 2023, 8:45 PM
ginsu committed rCOMM9e4fe445626b: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 21 2023, 8:45 PM
ginsu closed D9235: [lib] introduce createPendingPersonalThread function.
Sep 21 2023, 8:45 PM
ginsu committed rCOMM37a9f269f73e: [lib] introduce createPendingPersonalThread function.
Sep 21 2023, 8:45 PM
ginsu updated the diff for D9204: [lib] introduce threadInfosSelectorForThreadType selector.

rebase before landing

Sep 21 2023, 8:42 PM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

rebase before landing

Sep 21 2023, 8:41 PM
ginsu closed D9223: [nix] add logs to console while waiting for MariaDB to come up.
Sep 21 2023, 8:37 PM
ginsu committed rCOMM0bdf8c8da1a4: [nix] add logs to console while waiting for MariaDB to come up.
Sep 21 2023, 8:37 PM
ginsu requested review of D9261: [native] introduce useNavigateToUserProfileBottomSheet hook.
Sep 21 2023, 7:18 PM
ginsu updated the summary of D9260: [native] improve BottomSheet component close function.
Sep 21 2023, 7:00 PM
ginsu requested review of D9260: [native] improve BottomSheet component close function.
Sep 21 2023, 6:45 PM
ginsu attached a referenced file: F769080: Screenshot 2023-09-21 at 2.03.59 PM.png.
Sep 21 2023, 6:15 PM
ginsu attached a referenced file: F769081: Screenshot 2023-09-21 at 2.02.28 PM.png.
Sep 21 2023, 6:15 PM
ginsu attached a referenced file: F769082: Screenshot 2023-09-21 at 2.04.07 PM.png.
Sep 21 2023, 6:15 PM
ginsu attached a referenced file: F769112: Screen Recording 2023-09-21 at 2.10.10 PM.mov.
Sep 21 2023, 6:15 PM
ginsu attached a referenced file: F769113: Screen Recording 2023-09-21 at 2.11.46 PM.mov.
Sep 21 2023, 6:15 PM
ginsu attached a referenced file: F769117: Screenshot 2023-09-20 at 4.49.07 PM.png.
Sep 21 2023, 6:15 PM
ginsu updated the test plan for D9258: [native] introduce UserProfileRelationshipButton.
Sep 21 2023, 6:15 PM
ginsu updated subscribers of D9258: [native] introduce UserProfileRelationshipButton.
Sep 21 2023, 6:14 PM
ginsu requested review of D9258: [native] introduce UserProfileRelationshipButton.
Sep 21 2023, 6:14 PM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Sep 21 2023, 5:41 PM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

simplify/address comments

Sep 21 2023, 5:07 PM
ginsu closed D9203: [web] introduce AppearanceChangeModal.
Sep 21 2023, 4:52 PM
ginsu committed rCOMM57caceed7b27: [web] introduce AppearanceChangeModal.
Sep 21 2023, 4:52 PM
ginsu closed D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Sep 21 2023, 4:51 PM
ginsu committed rCOMM10935364caf9: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Sep 21 2023, 4:51 PM

Sep 20 2023

ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

rebase before landing

Sep 20 2023, 9:09 PM
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.

rebase before landing

Sep 20 2023, 9:07 PM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

address @atul's comments

Sep 20 2023, 9:05 PM
ginsu requested review of D9252: [lib/native] introduce UserProfileMessageButton.
Sep 20 2023, 9:02 PM
ginsu accepted D9250: [keyserver] Increase timeout for getInitialReduxState.
Sep 20 2023, 8:20 PM
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 20 2023, 7:12 PM
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.

D9235 factors out the logic in the search experience for creating a "pending" thread if that thread doesn't exist yet. This logic will be shared between the search experience and the user profiles experience.

Sep 20 2023, 7:12 PM
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
Sep 20 2023, 6:34 PM
ginsu attached a referenced file: F767708: Screenshot 2023-09-20 at 1.10.51 PM.png.
Sep 20 2023, 6:34 PM
ginsu attached a referenced file: F767831: Screen Recording 2023-09-20 at 2.32.13 PM.mov.
Sep 20 2023, 6:34 PM
ginsu updated the test plan for D9247: [lib] introduce useUserProfileThreadInfo hook.
Sep 20 2023, 6:34 PM
ginsu added inline comments to D9247: [lib] introduce useUserProfileThreadInfo hook.
Sep 20 2023, 5:24 PM
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 20 2023, 5:07 PM
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
Sep 20 2023, 5:07 PM
ginsu planned changes to D9247: [lib] introduce useUserProfileThreadInfo hook.

still need to write some comments + update test plan (will rerequest review when finished with that)

Sep 20 2023, 4:48 PM
ginsu requested review of D9247: [lib] introduce useUserProfileThreadInfo hook.
Sep 20 2023, 4:47 PM
ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

remove export

Sep 20 2023, 4:20 PM

Sep 19 2023

ginsu updated the diff for D9235: [lib] introduce createPendingPersonalThread function.

simplify

Sep 19 2023, 10:37 PM
ginsu updated the summary of D9235: [lib] introduce createPendingPersonalThread function.
Sep 19 2023, 10:30 PM
ginsu requested review of D9235: [lib] introduce createPendingPersonalThread function.
Sep 19 2023, 10:27 PM

Sep 18 2023

ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

add capitalization

Sep 18 2023, 10:30 PM
ginsu updated the diff for D9223: [nix] add logs to console while waiting for MariaDB to come up.

address comments. (changed log to say "Still waiting for MariaDB socket" in hopes that this is more clear/explicit)

Sep 18 2023, 10:27 PM
ginsu added inline comments to D9203: [web] introduce AppearanceChangeModal.
Sep 18 2023, 10:22 PM
ginsu updated the diff for D9203: [web] introduce AppearanceChangeModal.

address @atul's feedback

Sep 18 2023, 10:19 PM
ginsu requested review of D9223: [nix] add logs to console while waiting for MariaDB to come up.
Sep 18 2023, 9:20 PM
ginsu accepted D9221: [web] Fix capitalization of roles modal.
Sep 18 2023, 8:30 PM
ginsu added a comment to D9204: [lib] introduce threadInfosSelectorForThreadType selector.

How does the code for search results currently handle this?

Sep 18 2023, 1:28 PM

Sep 14 2023

ginsu added inline comments to D9205: [native] Introduce naive `ChatThreadListSearch` component.
Sep 14 2023, 8:46 PM
ginsu accepted D9205: [native] Introduce naive `ChatThreadListSearch` component.

accepting, but please take a look at the inline comments

Sep 14 2023, 8:10 PM
ginsu attached a referenced file: F759614: Screenshot 2023-09-14 at 2.04.17 PM.png.
Sep 14 2023, 6:09 PM
ginsu updated the summary of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 14 2023, 6:07 PM
ginsu requested review of D9204: [lib] introduce threadInfosSelectorForThreadType selector.
Sep 14 2023, 5:48 PM
ginsu added inline comments to D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Sep 14 2023, 5:05 PM
ginsu attached a referenced file: F759554: Screen Recording 2023-09-14 at 1.00.25 PM.mov.
Sep 14 2023, 5:03 PM
ginsu updated the test plan for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.
Sep 14 2023, 5:03 PM
ginsu updated the diff for D9120: [native] update UserProfileBottomSheet to get a userInfo from a userID.

address feedback

Sep 14 2023, 5:01 PM
ginsu requested review of D9203: [web] introduce AppearanceChangeModal.
Sep 14 2023, 4:23 PM
ginsu resigned from D9202: [keyserver/web/native] Covert AES-256 key from Uint8Array representation to hex string representation.

Code looks good to me, but resigning to give others a chance to review

Sep 14 2023, 3:35 PM
ginsu closed D9195: [web] introduce preferences settings in account settings.
Sep 14 2023, 3:29 PM
ginsu closed D9194: [web] introduce useStaffCanSee hook for web.
Sep 14 2023, 3:29 PM
ginsu committed rCOMMe14ab1b818cb: [web] introduce preferences settings in account settings.
Sep 14 2023, 3:29 PM
ginsu committed rCOMM00b30f802217: [web] introduce useStaffCanSee hook for web.
Sep 14 2023, 3:29 PM
ginsu closed D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Sep 14 2023, 3:29 PM
ginsu committed rCOMM1f06786df4ed: [lib/native] lift useIsCurrentUserStaff hook into lib.
Sep 14 2023, 3:29 PM
ginsu updated the diff for D9195: [web] introduce preferences settings in account settings.

address feedback

Sep 14 2023, 3:24 PM
ginsu added a comment to D9194: [web] introduce useStaffCanSee hook for web.

Seems reasonable, does it make sense to preemptively just put this in lib as well though like useIsCurrentUserStaff

Sep 14 2023, 3:19 PM

Sep 13 2023

ginsu closed D9119: [native] use stringForUserExplicit function to determine username text for profiles.
Sep 13 2023, 10:02 PM
ginsu committed rCOMMdf8e1881cd14: [native] use stringForUserExplicit function to determine username text for….
Sep 13 2023, 10:02 PM
ginsu requested review of D9195: [web] introduce preferences settings in account settings.
Sep 13 2023, 9:18 PM
ginsu requested review of D9194: [web] introduce useStaffCanSee hook for web.
Sep 13 2023, 9:09 PM
ginsu requested review of D9193: [lib/native] lift useIsCurrentUserStaff hook into lib.
Sep 13 2023, 8:59 PM
ginsu resigned from D9181: [keyserver] Generate an AES256 key (ephemeral) to encode.

Seems reasonable, but not super familiar with the requirements

Sep 13 2023, 8:32 PM
ginsu accepted D9191: [native] Remove `ChatThreadList` class component.
Sep 13 2023, 8:30 PM
ginsu accepted D9188: [native] Lift `onTabPress` to `ConnectedChatThreadList`.
Sep 13 2023, 8:25 PM
ginsu accepted D9184: [native] Lift `FlatList` to `ConnectedChatThreadList`.

One question inline

Sep 13 2023, 8:23 PM
ginsu accepted D9183: [native] Lift `floatingAction` to `ConnectedChatThreadList`.
Sep 13 2023, 8:16 PM
ginsu accepted D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.
Sep 13 2023, 8:13 PM
ginsu accepted D9180: [keyserver] Print out a QR code to the terminal.
Sep 13 2023, 4:52 PM
ginsu added a comment to D9180: [keyserver] Print out a QR code to the terminal.

Don't have a ton of experience with qr codes, but seems reasonable

Sep 13 2023, 4:52 PM
ginsu requested changes to D9174: [native] Replace `listDataSelector` with `useMemo` in `ChatThreadList`.

One concern inline

Sep 13 2023, 4:49 PM
ginsu accepted D9173: [native] Lift `renderItem` to `ConnectedChatThreadList`.
Sep 13 2023, 4:41 PM
First
Prev
Next