I applied changes from latest @ashoat suggestion but it forced me to change mergeUserToCollapsableInfo to perform deeper copy that initial single spread. Therefore re-requesting review.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 10 2024
Sep 10 2024
Sep 9 2024
Sep 9 2024
Implement DMActivityHandler
marcin committed rCOMMaf90fa403c02: Implement maunally marking DM thread as read/unread (authored by marcin).
Implement maunally marking DM thread as read/unread
Rebase before landing
Rebase before landing
Rename thick_sidebar -> dm_sidebar
rebase before landing
Rebase
Enable tracking update activity action for thick threads
marcin added a comment to D13190: Update badge count from JS on native taking into account thick threads.
In D13190#374009, @ashoat wrote:
- If we are connected to the tunnelbroker, we trust redux and update notifs storage (MMKV) with data from redux.
- If we are disconnected from the tunnelbroker, we trust notifs storage (MMKV) and fetch data from there.
Can you explain this approach in a bit more detail? Why do we trust Redux if (and only if?) we are connected to Tunnelbroker? And why do we trust notifs storage when we don't trust Redux?
In D13265#373994, @ashoat wrote:Just wondering, what codepath led to the ENCRYPTED notif? Curious why we saw that instead of Obj-C exception or C++ exception
marcin committed rCOMM6b3f5d4e2047: Fix broken collapsable notifs in badge only threads on iOS (authored by marcin).
Fix broken collapsable notifs in badge only threads on iOS
Move dm logic to hook
Rebase before landing
Implement updating DM thread subscription
Rebase before landing
Move dm logic to hook.
Sep 6 2024
Sep 6 2024
- Address review
- Refactor to execute DM logic in hook instead of component to match latest convention
marcin committed rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars (authored by marcin).
Extend pending thread IDs to support thick sidebars
Sep 5 2024
Sep 5 2024
Fix broken in-app notification on native
Rebase before landing
Sep 4 2024
Sep 4 2024
Sep 3 2024
Sep 3 2024
marcin updated the diff for D13210: Update badge count on web and desktop taking into account thick threads.
Rebase before landing
marcin updated the diff for D13190: Update badge count from JS on native taking into account thick threads.
Rebase before landing
Rebase before landing
Rebase before landing
marcin updated the diff for D13167: Implement thick thread badge updates and rescinds handling in native notifs code.
Rebase before landing
Rebase before landing
marcin updated the diff for D13165: Return single curve25519 string from NotificationsInboundKeysProvider.
Rebase before landing
marcin updated the diff for D13164: Implement code in lib to create thick threads rescinds and badge updates.
Rebase before landing
marcin updated the diff for D13163: Implement DMOperation and relevant spec for thread status change.
Rebase before landing
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin updated the diff for D13164: Implement code in lib to create thick threads rescinds and badge updates.
Make generic types more verbose
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin requested review of D13164: Implement code in lib to create thick threads rescinds and badge updates.
Fix iOS compilation
marcin updated the diff for D13164: Implement code in lib to create thick threads rescinds and badge updates.
Reduce code duplication - remove duplicated for loops over platform -> version key maps
Sep 2 2024
Sep 2 2024
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
Remove remaining usage of hardcoded NOTIFS.UNREAD_THICK_THREADS constant in CommCoreModule.cpp
marcin updated the diff for D13210: Update badge count on web and desktop taking into account thick threads.
Readabilty rename
marcin updated the diff for D13190: Update badge count from JS on native taking into account thick threads.
Readability rename
Share unread thick thread ids set key between C++, Java and Obj-C
marcin updated the diff for D13167: Implement thick thread badge updates and rescinds handling in native notifs code.
Extract notificationId string into a constant
marcin updated the diff for D13163: Implement DMOperation and relevant spec for thread status change.
Rename CHANGE_THREAD_STATUS_SPEC -> CHANGE_THREAD_READ_STATUS_SPEC
marcin added inline comments to D13210: Update badge count on web and desktop taking into account thick threads.
marcin added inline comments to D13190: Update badge count from JS on native taking into account thick threads.
marcin added inline comments to D13167: Implement thick thread badge updates and rescinds handling in native notifs code.
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
marcin added inline comments to D13164: Implement code in lib to create thick threads rescinds and badge updates.
Aug 29 2024
Aug 29 2024
marcin requested review of D13210: Update badge count on web and desktop taking into account thick threads.
marcin updated the diff for D13207: Use notificationsCreationData from queueFront in peer-to-peer-context.
rebase before landing
marcin published D13207: Use notificationsCreationData from queueFront in peer-to-peer-context for review.
marcin added inline comments to D13132: Implement ChangeThreadSubscriptionSpec and add ThreadSubscription to createThickRawThreadInfo.
marcin updated the diff for D13132: Implement ChangeThreadSubscriptionSpec and add ThreadSubscription to createThickRawThreadInfo.
- Addres review
- Rebase before landing
Aug 28 2024
Aug 28 2024
marcin requested review of D13190: Update badge count from JS on native taking into account thick threads.
marcin updated the diff for D13167: Implement thick thread badge updates and rescinds handling in native notifs code.
Use getStringSet instead of getStringSetSize
Refactor getStringSetSize to getStringSet
Aug 27 2024
Aug 27 2024
marcin updated the diff for D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.
fix missing avatar property assignment
marcin added inline comments to D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.
Rebase before landing
Rebase before landing
marcin updated the diff for D13121: Implement method to go from DMOperation -> [MessageData] for each dm op spec.
Rebase before landing
marcin updated the diff for D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.
Rebase before landing
Rebase before landing
Rebase before landing