Page MenuHomePhorge
Feed Search

Feb 28 2025

ashoat closed D14414: [native] Fix copying encrypted images on iOS.
Feb 28 2025, 9:51 PM
ashoat committed rCOMM66e8cbf090ee: [native] Fix copying encrypted images on iOS.
Feb 28 2025, 9:51 PM
ashoat committed rCOMM33f5b2d57510: [native] Update to react-native-gesture-handler@2.9.0.
Feb 28 2025, 9:50 PM
ashoat committed rCOMM14b87fd298f9: Revert "Tmate for iOS CI to debug".
Feb 28 2025, 9:50 PM
ashoat added a reverting change for rCOMM207609aaf9bb: Tmate for iOS CI to debug: rCOMM14b87fd298f9: Revert "Tmate for iOS CI to debug".
Feb 28 2025, 9:50 PM
ashoat committed rCOMM207609aaf9bb: Tmate for iOS CI to debug.
Feb 28 2025, 9:25 PM
ashoat committed rCOMMcc64f6c805dd: [lib] Minor fix to siwe patch.
Feb 28 2025, 9:25 PM
ashoat accepted D14053: [native] DisplayCommunityDirectoryPrompt.

Shouldn't D14391 be added to the stack here? You seem to be depending on it

Feb 28 2025, 7:37 AM

Feb 27 2025

ashoat committed rCOMM9e4a92343213: [terraform] Bump RabbitMQ engine_version to 3.12.13.
Feb 27 2025, 8:09 PM
ashoat committed rCOMMfeed126fa882: [terraform] Bump keyserver image to 1.0.155.
Feb 27 2025, 7:27 PM
ashoat added a reverting change for rCOMM9bd00d080a48: [lib] Temporarily flip useIsRestoreFlowEnabled to true: rCOMM2ee1094cc908: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 27 2025, 6:42 PM
ashoat committed rCOMM2ee1094cc908: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 27 2025, 6:42 PM
ashoat added a reverting change for rCOMM637bad1cdcde: [native] Temporary changes for staff release: rCOMM0682b2365132: Revert "[native] Temporary changes for staff release".
Feb 27 2025, 6:42 PM
ashoat committed rCOMM0682b2365132: Revert "[native] Temporary changes for staff release".
Feb 27 2025, 6:42 PM
ashoat committed rCOMMd8703be7333a: [native] codeVersion -> 466.
Feb 27 2025, 6:42 PM
ashoat committed rCOMM637bad1cdcde: [native] Temporary changes for staff release.
Feb 27 2025, 6:42 PM
ashoat committed rCOMM9bd00d080a48: [lib] Temporarily flip useIsRestoreFlowEnabled to true.
Feb 27 2025, 6:42 PM
ashoat committed rCOMMbd9de7b6608d: [native] codeVersion -> 465.
Feb 27 2025, 6:42 PM
ashoat committed rCOMM942f3d7bd0d0: [web][keyserver] codeVersion -> 155.
Feb 27 2025, 6:42 PM
ashoat added a comment to D14414: [native] Fix copying encrypted images on iOS.

An alternative approach, that doesn't require using temporary file:

  • Extract some logic from saveRemoteMediaToDisk() in`save-file.js`, with the following changes:
    • For encrypted media, call fetchAndDecryptMedia({ destination: 'data_uri' }) instead of destination: file
    • For non-encrypted, fetch base64 but don't save to file (skip last step)
  • call Clipboard.setImageFromBase64 - iOS implementation is in the patch, line 116
Feb 27 2025, 5:07 PM
ashoat closed D14413: Upgrade to Rust 1.85.
Feb 27 2025, 4:58 PM
ashoat committed rCOMM67fde31e015d: Upgrade to Rust 1.85.
Feb 27 2025, 4:58 PM
ashoat added a comment to D14413: Upgrade to Rust 1.85.

Okay, in order to fix CI and unblock the builds, I'll go ahead and land this on the assumption that things are working. I've created a task to confirm that it's working once things are deployed in production; assigned to @bartek for now since @kamil is out sick.

Feb 27 2025, 4:57 PM
ashoat requested review of D14414: [native] Fix copying encrypted images on iOS.
Feb 27 2025, 4:41 PM
ashoat added a comment to D14417: [native] Remove background identity login handler.

Should we bump the version in keyserver/src/session/version.js along with this change?

Feb 27 2025, 4:36 PM
ashoat added a comment to D14413: Upgrade to Rust 1.85.

I'm not entirely sure what functionality I should be testing to verify that backup-client-wasm still works correctly on web. If reviewers have any context here, please feel free to test that functionality on https://comm.software/

Feb 27 2025, 6:43 AM
ashoat updated the summary of D14413: Upgrade to Rust 1.85.
Feb 27 2025, 6:42 AM
ashoat updated the summary of D14413: Upgrade to Rust 1.85.
Feb 27 2025, 6:42 AM
ashoat updated the test plan for D14413: Upgrade to Rust 1.85.
Feb 27 2025, 6:38 AM

Feb 26 2025

ashoat published D14413: Upgrade to Rust 1.85 for review.
Feb 26 2025, 10:44 PM
ashoat added a comment to D14412: [native] Fall back to v1 login after `use_v1_flow` response.

Looks great!

Feb 26 2025, 6:30 PM
ashoat added a reverting change for rCOMMa415a12d7f27: [lib] Temporarily flip useIsRestoreFlowEnabled to true: rCOMM7baa694107c2: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 26 2025, 7:57 AM
ashoat added a reverting change for rCOMM69879c7f1065: [native] Temporary changes for staff release: rCOMM8f3d64e65a8d: Revert "[native] Temporary changes for staff release".
Feb 26 2025, 7:57 AM
ashoat committed rCOMM7baa694107c2: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 26 2025, 7:57 AM
ashoat committed rCOMM8f3d64e65a8d: Revert "[native] Temporary changes for staff release".
Feb 26 2025, 7:57 AM
ashoat committed rCOMM71c3b45b3fdd: [native] codeVersion -> 464.
Feb 26 2025, 7:57 AM
ashoat committed rCOMM69879c7f1065: [native] Temporary changes for staff release.
Feb 26 2025, 7:57 AM
ashoat committed rCOMMa415a12d7f27: [lib] Temporarily flip useIsRestoreFlowEnabled to true.
Feb 26 2025, 7:57 AM
ashoat committed rCOMM47202d9057d6: [native] codeVersion -> 463.
Feb 26 2025, 7:57 AM
ashoat committed rCOMMe1fd936de3df: [web][keyserver] codeVersion -> 154.
Feb 26 2025, 7:57 AM

Feb 25 2025

ashoat closed D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025, 5:23 PM
ashoat committed rCOMM62ab45bf2239: [lib] Avoid unnecessarily mutating MessageStore on….
Feb 25 2025, 5:23 PM
ashoat closed D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
Feb 25 2025, 5:23 PM
ashoat committed rCOMM4f5e12f406c3: [lib] Prevent useMessageInfoForPreview from fetching messages that get….
Feb 25 2025, 5:23 PM
ashoat closed D14400: [lib] Add numMessagesToFetch param to useFetchMessages.
Feb 25 2025, 5:23 PM
ashoat committed rCOMM31ae31d09cad: [lib] Add numMessagesToFetch param to useFetchMessages.
Feb 25 2025, 5:23 PM
ashoat closed D14399: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.
Feb 25 2025, 5:23 PM
ashoat committed rCOMM40501edd21e2: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.
Feb 25 2025, 5:23 PM
ashoat added inline comments to D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025, 5:21 PM
ashoat updated the diff for D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.

Feedback

Feb 25 2025, 5:16 PM
ashoat added inline comments to D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
Feb 25 2025, 5:16 PM
ashoat added inline comments to D14412: [native] Fall back to v1 login after `use_v1_flow` response.
Feb 25 2025, 5:07 PM
ashoat added a comment to D14411: [native] Remove tipHorizontalOffset from NUXTipsOverlay.

Was the NUX tooltips ever implemented in Reanimated v1? It's relatively new in our codebase

Feb 25 2025, 5:06 PM
ashoat accepted D14403: [nix] Add jq tool to dev shell.
Feb 25 2025, 3:59 PM
ashoat accepted D14404: [scripts] Script to reset keyserver owner in DDB.
Feb 25 2025, 3:59 PM
ashoat added inline comments to D14404: [scripts] Script to reset keyserver owner in DDB.
Feb 25 2025, 3:49 PM
ashoat requested review of D14402: [lib] Avoid unnecessarily mutating MessageStore on processServerRequestsActionType.
Feb 25 2025, 9:54 AM
ashoat requested review of D14401: [lib] Prevent useMessageInfoForPreview from fetching messages that get immediately pruned.
Feb 25 2025, 9:30 AM
ashoat requested review of D14400: [lib] Add numMessagesToFetch param to useFetchMessages.
Feb 25 2025, 9:11 AM
ashoat requested review of D14399: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.
Feb 25 2025, 8:53 AM
ashoat closed D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 25 2025, 8:36 AM
ashoat committed rCOMMfa0d0c36cdce: [lib] Introduce useGetMessageAuthor hook.
Feb 25 2025, 8:36 AM
ashoat updated the diff for D14395: [lib] Introduce useGetMessageAuthor hook.

Avoid fetching latest message in reactionMessageSpec.getLastUpdatedTime until function is actually called

Feb 25 2025, 8:15 AM

Feb 24 2025

ashoat updated the diff for D14395: [lib] Introduce useGetMessageAuthor hook.

Review

Feb 24 2025, 5:13 PM
ashoat added inline comments to D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 24 2025, 5:12 PM
ashoat added inline comments to D14397: [native] prevent leaving restore screen when falling back to v1.
Feb 24 2025, 5:10 PM
ashoat added a comment to D14398: [native] disable navigation in `RestoreBackupScreen`.

Just confirming – is this screen only used when the restore is in-progress? If the button to start is on this screen too, we might want to only prevent the user from navigating away after the button is pressed

Feb 24 2025, 5:06 PM
ashoat accepted D14396: [native] fix `currentInitializeCryptoAccountPromise`.
Feb 24 2025, 2:57 PM

Feb 22 2025

ashoat updated the test plan for D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 22 2025, 10:55 AM
ashoat accepted D14308: [native] Migrate fling functionality in FullScreenViewModal.
Feb 22 2025, 7:47 AM
ashoat accepted D14307: [native] Migrate recenter functionality in FullScreenViewModal.
Feb 22 2025, 7:47 AM
ashoat accepted D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 22 2025, 7:47 AM
ashoat committed rCOMM27b7aa32d6da: [lib] Fix comments in thread-time.js.
Feb 22 2025, 12:06 AM

Feb 21 2025

ashoat requested review of D14395: [lib] Introduce useGetMessageAuthor hook.
Feb 21 2025, 12:00 PM
ashoat added inline comments to D14298: [native] Migrate orientation logic in FullScreenViewModal to functional component.
Feb 21 2025, 6:03 AM
ashoat added inline comments to D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Feb 21 2025, 5:58 AM
ashoat added a comment to D14308: [native] Migrate fling functionality in FullScreenViewModal.

Just leaving a note here that we should address this comment in this diff

Feb 21 2025, 5:54 AM
ashoat added inline comments to D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 21 2025, 5:51 AM
ashoat added a comment to D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.

Adding support for this would be complicated as there is no simple way of running a couple animations at once but consider that this is an animation after a double click. What other animation can be run while/after user double clicks the image? To double click user needs to stop doing anything for a moment and any animation will finish in the meantime.

Feb 21 2025, 5:45 AM
ashoat added inline comments to D14301: [native] Migrate buttons refs and measuring in FullScreenViewModal.
Feb 21 2025, 5:28 AM

Feb 20 2025

ashoat accepted D14313: [native] Migrate render function and finish FullScreenViewModal migration to functional component.

A lovely feeling to get to the end of the stack here. Great work on all of this, @angelika!!

Feb 20 2025, 4:59 AM
ashoat added inline comments to D14312: [native] Migrate animated styles to Reanimated v2 API in FullScreenViewModal.
Feb 20 2025, 4:50 AM
ashoat requested changes to D14308: [native] Migrate fling functionality in FullScreenViewModal.
Feb 20 2025, 4:36 AM
ashoat added inline comments to D14308: [native] Migrate fling functionality in FullScreenViewModal.
Feb 20 2025, 4:36 AM
ashoat accepted D14391: [native] ColdStartTracker.
Feb 20 2025, 4:22 AM
ashoat added inline comments to D14307: [native] Migrate recenter functionality in FullScreenViewModal.
Feb 20 2025, 2:02 AM
ashoat added inline comments to D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 20 2025, 1:57 AM
ashoat added inline comments to D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 20 2025, 1:51 AM
ashoat added inline comments to D14306: [native] Migrate backdropOpacityUpdate in FullScreenViewModal.
Feb 20 2025, 1:32 AM
ashoat added a comment to D14309: [native] Cancel animations when gesture is started in FullScreenViewModal.

I'd be surprised if this diff was the cause, as here we cancel animations at the start of a pan or pinch, but in the video we see an issue at the conclusion of a pan.

Feb 20 2025, 12:42 AM
ashoat added inline comments to D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.
Feb 20 2025, 12:34 AM
ashoat added inline comments to D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.
Feb 20 2025, 12:31 AM
ashoat added inline comments to D14305: [native] Migrate double tap gesture handling in FullScreenViewModal.
Feb 20 2025, 12:28 AM

Feb 19 2025

ashoat added a comment to D14387: [native] wait for Tunnelbroker connection when adding secondary device.

The diff is titled [lib] but only seems to touch [native]. Wondering if we need something similar on the secondary device side (for both native / web), or if we already wait for the Tunnelbroker connection there (since we need to open a special "unauthorized" connection anyways)

Feb 19 2025, 12:13 AM

Feb 18 2025

ashoat added inline comments to D14304: [native] Migrate single tap gesture handling in FullScreenViewModal.
Feb 18 2025, 10:53 AM
ashoat accepted D14378: [keyserver] boost certain community IDs.

Can you share a screenshot of the order we end up seeing? Curious in what order the boosted communities will appear

Feb 18 2025, 2:38 AM

Feb 17 2025

ashoat accepted D14204: [native] fix avatars in directory.
Feb 17 2025, 5:09 AM
ashoat committed rCOMM70f4f0e8b4d8: [terraform] Bump keyserver image to 1.0.153.
Feb 17 2025, 4:47 AM

Feb 16 2025

ashoat added a reverting change for rCOMM2b0ed600c9b1: [lib] Temporarily flip useIsRestoreFlowEnabled to true: rCOMMfb0813a39ae5: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 16 2025, 9:43 AM
ashoat committed rCOMMfb0813a39ae5: Revert "[lib] Temporarily flip useIsRestoreFlowEnabled to true".
Feb 16 2025, 9:43 AM