Page MenuHomePhabricator
Feed Advanced Search

Mar 30 2023

ginsu requested review of D7265: [native] improve avatar component prop types.
Mar 30 2023, 11:28 PM
ginsu requested review of D7264: [lib/native] change useGetAvatarForThread to useAvatarForThread.
Mar 30 2023, 11:25 PM
ginsu retitled D7260: [native/lib] introduce useENSResolvedAvatar hook in avatar-utils from [native/lib] introduce useAvatarForUserID hook in avatar-utils to [native/lib] introduce useENSResolvedAvatar hook in avatar-utils.
Mar 30 2023, 11:18 PM
ginsu added inline comments to D7262: [native] introude thread avatar component.
Mar 30 2023, 11:11 PM
ginsu updated the diff for D7263: [native] switch all thread avatars to use ThreadAvatar component instead of Avatar.

address ashoat's comments

Mar 30 2023, 11:07 PM
ginsu updated the diff for D7262: [native] introude thread avatar component.

address ashoat's comments

Mar 30 2023, 11:02 PM
ginsu added inline comments to D7260: [native/lib] introduce useENSResolvedAvatar hook in avatar-utils.
Mar 30 2023, 10:59 PM
ginsu updated the diff for D7260: [native/lib] introduce useENSResolvedAvatar hook in avatar-utils.

address ashoat's commentsy

Mar 30 2023, 10:54 PM
ginsu closed D7259: [native] switch all user avatars to use UserAvatar component instead of Avatar.
Mar 30 2023, 10:38 PM
ginsu committed rCOMM7c41c43a1737: [native] switch all user avatars to use UserAvatar component instead of Avatar (authored by ginsu).
[native] switch all user avatars to use UserAvatar component instead of Avatar
Mar 30 2023, 10:38 PM
ginsu updated the diff for D7259: [native] switch all user avatars to use UserAvatar component instead of Avatar.

rebase before landing

Mar 30 2023, 9:59 PM
ginsu requested review of D7263: [native] switch all thread avatars to use ThreadAvatar component instead of Avatar.
Mar 30 2023, 3:29 PM
ginsu requested review of D7262: [native] introude thread avatar component.
Mar 30 2023, 3:19 PM
ginsu requested review of D7260: [native/lib] introduce useENSResolvedAvatar hook in avatar-utils.
Mar 30 2023, 2:06 PM
ginsu requested review of D7259: [native] switch all user avatars to use UserAvatar component instead of Avatar.
Mar 30 2023, 12:54 PM
ginsu closed D7246: [native] introduce user avatar component.
Mar 30 2023, 10:31 AM
ginsu committed rCOMM719e3a8ddc58: [native] introduce user avatar component (authored by ginsu).
[native] introduce user avatar component
Mar 30 2023, 10:31 AM
ginsu closed D7187: [native] extend avatar component to handle images.
Mar 30 2023, 10:26 AM
ginsu committed rCOMM2cd9dcd9e041: [native] extend avatar component to handle images (authored by ginsu).
[native] extend avatar component to handle images
Mar 30 2023, 10:26 AM
ginsu updated the diff for D7246: [native] introduce user avatar component.

rebase before landing

Mar 30 2023, 9:47 AM
ginsu updated the diff for D7187: [native] extend avatar component to handle images.

address atuls comment and rebase before landing

Mar 30 2023, 9:47 AM
ginsu added inline comments to D7246: [native] introduce user avatar component.
Mar 30 2023, 9:44 AM
ginsu added inline comments to D7246: [native] introduce user avatar component.
Mar 30 2023, 8:28 AM
ginsu closed D7245: [native] update Image import to use expo-image in Multimedia component.
Mar 30 2023, 8:14 AM
ginsu committed rCOMM17181153bdc9: [native] update Image import to use expo-image in Multimedia component (authored by ginsu).
[native] update Image import to use expo-image in Multimedia component
Mar 30 2023, 8:14 AM
ginsu added inline comments to D7246: [native] introduce user avatar component.
Mar 30 2023, 8:06 AM

Mar 29 2023

ginsu added reviewers for D7246: [native] introduce user avatar component: ashoat, atul.
Mar 29 2023, 4:49 PM
ginsu added inline comments to D7246: [native] introduce user avatar component.
Mar 29 2023, 4:49 PM
ginsu requested review of D7246: [native] introduce user avatar component.
Mar 29 2023, 4:42 PM
ginsu accepted D7017: [web] Added displaying 'Labels' to InlineEngagment.
Mar 29 2023, 4:07 PM
ginsu requested review of D7245: [native] update Image import to use expo-image in Multimedia component.
Mar 29 2023, 4:03 PM
ginsu retitled D7187: [native] extend avatar component to handle images from [draft][native] extend avatar component to handle images to [native] extend avatar component to handle images.
Mar 29 2023, 4:02 PM
ginsu updated the diff for D7187: [native] extend avatar component to handle images.

have Avatar component use Multimedia instead of RemoteImage

Mar 29 2023, 3:55 PM
ginsu closed D7242: [landing] add ted to team page.
Mar 29 2023, 12:20 PM
ginsu committed rCOMM81338ec0e683: [landing] add ted to team page (authored by ginsu).
[landing] add ted to team page
Mar 29 2023, 12:20 PM
ginsu requested review of D7242: [landing] add ted to team page.
Mar 29 2023, 12:03 PM

Mar 28 2023

ginsu added inline comments to D7192: [web] introduce avatar component.
Mar 28 2023, 12:31 PM

Mar 27 2023

ginsu requested review of D7210: [web] render thread avatars on chat screen.
Mar 27 2023, 4:37 PM
ginsu requested review of D7209: [web] render thread avatars in the community drawer.
Mar 27 2023, 4:33 PM
ginsu requested review of D7208: [web] render user avatars in typeahead tooltip.
Mar 27 2023, 4:24 PM
ginsu requested review of D7207: [web] render user avatars in thread memebers modal.
Mar 27 2023, 4:20 PM
ginsu updated the summary of D7205: [web] render user avatars in account relationship lists.
Mar 27 2023, 4:17 PM
ginsu requested review of D7206: [web] render user avatars in chat thread composer.
Mar 27 2023, 4:14 PM
ginsu requested review of D7205: [web] render user avatars in account relationship lists.
Mar 27 2023, 4:05 PM
ginsu closed D7138: [native] render the rest of the thread avatars.
Mar 27 2023, 3:38 PM
ginsu committed rCOMM086416ce36d8: [native] render the rest of the thread avatars (authored by ginsu).
[native] render the rest of the thread avatars
Mar 27 2023, 3:38 PM
ginsu updated the diff for D7138: [native] render the rest of the thread avatars.

rebase before landing

Mar 27 2023, 3:18 PM
ginsu closed D7136: [native] render thread avatars in community drawer.
Mar 27 2023, 3:00 PM
ginsu committed rCOMMb2a49aa0e122: [native] render thread avatars in community drawer (authored by ginsu).
[native] render thread avatars in community drawer
Mar 27 2023, 3:00 PM
ginsu attached a referenced file: F448401: Screenshot 2023-03-27 at 5.53.19 PM.png.
Mar 27 2023, 2:58 PM
ginsu attached a referenced file: F448403: Screenshot 2023-03-27 at 5.54.08 PM.png.
Mar 27 2023, 2:58 PM
ginsu updated the summary of D7196: [web] render user avatars in message reactions modal.
Mar 27 2023, 2:58 PM
ginsu updated the test plan for D7195: [web] render user avatars in chat screen.
Mar 27 2023, 2:46 PM
ginsu attached a referenced file: F448367: Screenshot 2023-03-27 at 5.42.09 PM.png.
Mar 27 2023, 2:43 PM
ginsu attached a referenced file: F448368: Screenshot 2023-03-27 at 5.41.51 PM.png.
Mar 27 2023, 2:43 PM
ginsu updated the test plan for D7195: [web] render user avatars in chat screen.
Mar 27 2023, 2:43 PM
ginsu attached a referenced file: F448291: Screenshot 2023-03-27 at 4.50.44 PM.png.
Mar 27 2023, 2:03 PM
ginsu attached a referenced file: F448292: Screenshot 2023-03-27 at 4.52.56 PM.png.
Mar 27 2023, 2:03 PM
ginsu attached a referenced file: F448293: Screen Recording 2023-03-27 at 4.57.30 PM.mov.
Mar 27 2023, 2:03 PM
ginsu attached a referenced file: F448300: Screen Recording 2023-03-27 at 4.58.34 PM.mov.
Mar 27 2023, 2:03 PM
ginsu attached a referenced file: F448314: Screen Recording 2023-03-27 at 5.02.08 PM.mov.
Mar 27 2023, 2:03 PM
ginsu attached a referenced file: F448309: Screen Recording 2023-03-27 at 5.01.03 PM.mov.
Mar 27 2023, 2:03 PM
ginsu updated the summary of D7195: [web] render user avatars in chat screen.
Mar 27 2023, 2:02 PM
ginsu accepted D7204: [keyserver] Get rid of `ExperimentalWarning`s in `keyserver` logs.

nice this is very helpful

Mar 27 2023, 1:44 PM
ginsu updated the diff for D7136: [native] render thread avatars in community drawer.

rebase before landing

Mar 27 2023, 1:07 PM
ginsu added a comment to D7187: [native] extend avatar component to handle images.

Is this diff still in [draft] state? Or is it ready to review?

Mar 27 2023, 12:06 PM
ginsu closed D7137: [native] render thread avatars for parent/child threads in thread settings.
Mar 27 2023, 11:39 AM
ginsu committed rCOMM4bc0989e7904: [native] render thread avatars for parent/child threads in thread settings (authored by ginsu).
[native] render thread avatars for parent/child threads in thread settings
Mar 27 2023, 11:39 AM
ginsu updated the diff for D7192: [web] introduce avatar component.

address atuls comments

Mar 27 2023, 11:34 AM
ginsu updated the diff for D7137: [native] render thread avatars for parent/child threads in thread settings.

rebase before landing/updated order in stack so I can unblock landing this diff

Mar 27 2023, 11:21 AM
ginsu updated the summary of D7137: [native] render thread avatars for parent/child threads in thread settings.
Mar 27 2023, 11:18 AM
ginsu added inline comments to D7136: [native] render thread avatars in community drawer.
Mar 27 2023, 11:15 AM
ginsu added a comment to D7137: [native] render thread avatars for parent/child threads in thread settings.

Accepting to unblock but the pattern of copy-paste is concerning

Mar 27 2023, 11:14 AM
ginsu added inline comments to D7136: [native] render thread avatars in community drawer.
Mar 27 2023, 8:51 AM
ginsu closed D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.
Mar 27 2023, 8:44 AM
ginsu committed rCOMMf55b55b3fef7: [native] render thread avatar in CHANNEL AVATAR thread settings section (authored by ginsu).
[native] render thread avatar in CHANNEL AVATAR thread settings section
Mar 27 2023, 8:44 AM
ginsu closed D7134: [native] update message list header to new design.
Mar 27 2023, 8:41 AM
ginsu committed rCOMM2eac9ba06075: [native] update message list header to new design (authored by ginsu).
[native] update message list header to new design
Mar 27 2023, 8:41 AM
ginsu added inline comments to D7136: [native] render thread avatars in community drawer.
Mar 27 2023, 8:26 AM
ginsu updated the diff for D7135: [native] render thread avatar in CHANNEL AVATAR thread settings section.

rebase before landing

Mar 27 2023, 8:19 AM
ginsu updated the diff for D7134: [native] update message list header to new design.

rebase before landing

Mar 27 2023, 8:18 AM
ginsu added inline comments to D7134: [native] update message list header to new design.
Mar 27 2023, 8:16 AM
ginsu requested review of D7196: [web] render user avatars in message reactions modal.
Mar 27 2023, 7:45 AM
ginsu requested review of D7195: [web] render user avatars in chat screen.
Mar 27 2023, 7:22 AM
ginsu requested review of D7194: [web] render user avatar in account screen.
Mar 27 2023, 7:17 AM
ginsu requested review of D7192: [web] introduce avatar component.
Mar 27 2023, 7:03 AM
ginsu requested review of D7187: [native] extend avatar component to handle images.
Mar 27 2023, 6:50 AM

Mar 26 2023

ginsu accepted D7165: [lib] Introduce useENSAvatar hook.
Mar 26 2023, 9:35 PM
ginsu closed D7132: [lib] introduce useGetAvatarForThread hook.
Mar 26 2023, 7:16 PM
ginsu committed rCOMM112846eaebdd: [lib] introduce useGetAvatarForThread hook (authored by ginsu).
[lib] introduce useGetAvatarForThread hook
Mar 26 2023, 7:16 PM
ginsu closed D7178: [lib] introduce getUserAvatarForThread function.
Mar 26 2023, 7:13 PM
ginsu committed rCOMM82a9fdc14701: [lib] introduce getUserAvatarForThread function (authored by ginsu).
[lib] introduce getUserAvatarForThread function
Mar 26 2023, 7:13 PM
ginsu closed D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.
Mar 26 2023, 6:57 PM
ginsu committed rCOMM35699428c66f: [keyserver/lib/native/web] introduce color-utils and move color functions from… (authored by ginsu).
[keyserver/lib/native/web] introduce color-utils and move color functions from…
Mar 26 2023, 6:57 PM
ginsu updated the diff for D7132: [lib] introduce useGetAvatarForThread hook.

rebase before landing

Mar 26 2023, 6:50 PM
ginsu updated the diff for D7178: [lib] introduce getUserAvatarForThread function.

address ashoats comment

Mar 26 2023, 6:48 PM
ginsu updated the diff for D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.

rebase before landing

Mar 26 2023, 6:38 PM
ginsu added inline comments to D7178: [lib] introduce getUserAvatarForThread function.
Mar 26 2023, 6:36 PM
ginsu added a comment to D7177: [keyserver/lib/native/web] introduce color-utils and move color functions from thread-utils to color-utils.

Not familiar with that error myself, wondering what "initialization" means in this context (is it a circular dependency issue?)

Mar 26 2023, 6:29 PM
ginsu added inline comments to D7137: [native] render thread avatars for parent/child threads in thread settings.
Mar 26 2023, 12:18 AM