In D8860#263537, @ginsu wrote:Are you sure that overlapping thread list a bit is okay?
Currently all our tooltips do this, so I thought it was okay to keep this consistent behavior.
Curious for Ted's take
cc @ted
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Sep 27 2023
Sep 27 2023
• ted added inline comments to D9286: [native] make user profiles accessible from RelationshipListItem.
Aug 25 2023
Aug 25 2023
Aug 22 2023
Aug 22 2023
• ted added a comment to D8821: [web] Create a new 'secondary device' screen that will generate the QR code.
In D8821#262313, @ashoat wrote:Is there a way we can try to make this actually match the style of the main "Sign in to Comm" modal? It frankly looks completely different, in terms of color scheme, navigation, organization, etc. I think we need to do some more work on the design here, but open to landing this diff to unblock Rohan for the time being
Aug 21 2023
Aug 21 2023
• ted added a comment to D8821: [web] Create a new 'secondary device' screen that will generate the QR code.
In D8821#261544, @rohan wrote:In D8821#261190, @ted wrote:Thanks for the tag! I do agree that rounding the corner of the box will be better here. Our corner radiuses that we have been using is 8px.
Looking at the entire screen now, I think it may be better to contain all the elements in QR scanning step within a modal, instead of having just on the screen. I can take a pass on this.
Sounds good, thanks! I'll hold off until a design is ready so I can update this directly before landing
Aug 17 2023
Aug 17 2023
• ted added a comment to D8821: [web] Create a new 'secondary device' screen that will generate the QR code.
In D8821#261124, @rohan wrote:In D8821#260684, @ashoat wrote:The square box here doesn't look super on-brand for us... we usually have rounded corners, don't we?
I wonder if we need to take another pass on the design here
cc @ted for your thoughts
Aug 16 2023
Aug 16 2023
• ted added a comment to D8821: [web] Create a new 'secondary device' screen that will generate the QR code.
Jul 14 2023
Jul 14 2023
• ted added a comment to D8445: [native] Prevent duplicate role names in one community on the client.
Jul 13 2023
Jul 13 2023
• ted added a comment to D8445: [native] Prevent duplicate role names in one community on the client.
Hey @rohan, thanks for the tag! I agree on keeping things consistent. I'll take a look at the design we had for the web version of this state so the native one can match. Will get back on this diff Friday afternoon, thanks!
Jul 6 2023
Jul 6 2023
Jun 13 2023
Jun 13 2023
Agree with @atul as well.
• ted added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
In D8137#242031, @rohan wrote:In D8137#242030, @ted wrote:Hey @rohan, thanks for the screenshots! It does look a bit big on the web modal. In the designs, I do have a size that fits nicer. Is it possible to match the design size?
We could probably match it, though it'd mean introducing a new 'size' to the avatars, @atul and @ginsu I believe worked on that so they can probably help make a call here
• ted added a comment to D8137: [web] Create a modal that allows admins to change a member's role (modal, description, avatar).
In D8137#242017, @rohan wrote:
Jun 12 2023
Jun 12 2023
• ted added inline comments to D8156: [native] Create a new screen that will show the role change information.
Jun 9 2023
Jun 9 2023
Jun 6 2023
Jun 6 2023
• ted added a comment to D8068: [native] Refactor the members list to support any variety of role labels.
CC @ted for design (current design doesn't looks great imo. Text seems busy + don't think it looks great left-aligned with avatar on next line. Could we consider alternative approaches? I've seen other messaging apps indicate admin vs. "member" with a crown icon for example. Maybe roles could have icons?)
Jun 5 2023
Jun 5 2023
• ted added inline comments to D7943: [landing] introduce logo svg assets for competitor comparison.
May 22 2023
May 22 2023
May 19 2023
May 19 2023
Nice! Thanks
Cool, thank you for the screen shots to provide context!
Sounds good, thanks for letting me know! These grays are similar enough that updating the calendar is fine.