In D8445#250540, @ginsu wrote:

Code looks good, but I feel that navigating the user away from the create role screen on an error is not a great experience. If I encountered an error because I chose a duplicate name, as a user I would expect that I would stay on the same page so that I could quickly fix the name and try again.

I agree, navigating away from the screen seems to be the default behavior of using displayActionResultModal.

cc @ted @ashoat from what we discussed in Linear, wondering if an alternative makes more sense here, like a red variant of the 'notice box' component used in the change-roles screen may be better? It's not actually a component yet but might be simple enough to refactor into one

I agree, navigating away from the screen seems to be the default behavior of using displayActionResultModal.

Why is that? Looking at the code, I don't follow why that should be the case. I suspect something weird is going on here.

cc @ted @ashoat from what we discussed in Linear, wondering if an alternative makes more sense here, like a red variant of the 'notice box' component used in the change-roles screen may be better? It's not actually a component yet but might be simple enough to refactor into one

Is the reason we're considering this because we can't figure out a way to show the "toast" (ActionResultModal) without dismissing the Change Role screen? Or was it in the designs that we should be dismissing the Change Role screen?

In D8445#250607, @ashoat wrote:

I agree, navigating away from the screen seems to be the default behavior of using displayActionResultModal.

Why is that? Looking at the code, I don't follow why that should be the case. I suspect something weird is going on here.

I'm not certain, I'm looking into it to determine whether it's with the way I'm handling navigation perhaps, or if there is another reason. My calling it 'default' behavior was incorrect though

cc @ted @ashoat from what we discussed in Linear, wondering if an alternative makes more sense here, like a red variant of the 'notice box' component used in the change-roles screen may be better? It's not actually a component yet but might be simple enough to refactor into one

Is the reason we're considering this because we can't figure out a way to show the "toast" (ActionResultModal) without dismissing the Change Role screen? Or was it in the designs that we should be dismissing the Change Role screen?

There weren't any official designs for handling this behavior, we just talked about it on the Linear task linked in the diff description. I only suggested it because I realized for change roles we use a box alert to prevent the user from reaching a state of error, so I was curious if it would be good to have similar behavior across actions surrounding roles, like here when creating a role.

I'm open to it if it improves consistency, but I'd want to see side-by-side examples of what we're talking about here (changes roles screen, what we're currently doing here, and what you're proposing we do here). I'd also like to hear from Ted about it

Hey @rohan, thanks for the tag! I agree on keeping things consistent. I'll take a look at the design we had for the web version of this state so the native one can match. Will get back on this diff Friday afternoon, thanks!

For web, I believe we have the notice box within the change role modal that is always displayed. @rohan In the Linear comments DES-44, we talked about toast alerts. We're you thinking of using the notice box to behave as a toast? Just making sure.

Confirmed with @ted offline that a toast alert is the way to go here