Page MenuHomePhabricator

[native] Display an action sheet with the 'edit role' option
ClosedPublic

Authored by rohan on Jul 17 2023, 10:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 2:45 PM
Unknown Object (File)
Sat, Nov 9, 2:34 PM
Unknown Object (File)
Sat, Nov 9, 10:48 AM
Unknown Object (File)
Sat, Nov 9, 10:47 AM
Unknown Object (File)
Sat, Nov 9, 10:45 AM
Unknown Object (File)
Sat, Nov 9, 10:44 AM
Unknown Object (File)
Sat, Nov 9, 8:28 AM
Unknown Object (File)
Sat, Nov 9, 2:36 AM
Subscribers

Details

Summary

The first option we display to the user is an "Edit role" item, where clicking it will take them to the role name / permissions screen. This diff just handles the action sheet, but the next one will
handle responding to pressing the 'Edit role' option. Down the line, I will also be adding the 'Delete' option to the action sheet.

ENG-4368.

Depends on D8522

Test Plan

Verified that on iOS and Android, the action sheet looks as expected.

Screenshot 2023-07-17 at 1.41.51 PM.png (1×1 px, 635 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Clean up options/icons logic

accepting so I don't block this diff and also my concerns are outside the scope of this diff; however, it is becoming very obvious that we need our own shared action sheet component that abstracts a lot of the similar patterns surrounding the actions sheet (only showing cancel for iOS in options, the cancelButtonIndex, the userInterfaceStyle, etc). This task should help with addressing this concern too since we should be able to deprecate most of this logic in favor for our own custom bottomsheet.

This revision is now accepted and ready to land.Jul 20 2023, 3:24 PM
In D8523#252704, @ginsu wrote:

accepting so I don't block this diff and also my concerns are outside the scope of this diff; however, it is becoming very obvious that we need our own shared action sheet component that abstracts a lot of the similar patterns surrounding the actions sheet (only showing cancel for iOS in options, the cancelButtonIndex, the userInterfaceStyle, etc). This task should help with addressing this concern too since we should be able to deprecate most of this logic in favor for our own custom bottomsheet.

Yeah I completely agree with this, I think converting to a custom bottomsheet (or at the very least in the short term having a shared action sheet component if the bottomsheet won't be prioritized) is going to help keep things consistent, and also make the conversion from actionsheet --> bottomsheet a lot easier

This revision was landed with ongoing or failed builds.Jul 31 2023, 6:15 PM
This revision was automatically updated to reflect the committed changes.