Details

Reviewers

atul
ginsu

Commits

rCOMM4479b9f88564: [native] Navigate to a screen to create a new role

Summary

Following the community roles screen, clicking the button should navigate to a new screen that will allow admins to create new roles with a set of permissions. The actual screen will be filled out in a following diff, this just handles the navigation to what will be the create roles screen.

Depends on D8359

ENG-4170

Test Plan

Confirmed that the navigation works and the animation from the previous screen to the new screen is good

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 29 2023, 9:50 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 29 2023, 9:50 AM

rohan edited the summary of this revision. (Show Details)Jun 29 2023, 9:52 AM

rohan edited the test plan for this revision. (Show Details)

rohan added a parent revision: D8359: [native] Create the community roles screen.

rohan attached a referenced file: F612763: Simulator Screen Recording - iPhone 14 Pro - 2023-06-29 at 12.51.41.mp4. (Show Details)

Harbormaster completed remote builds in B20624: Diff 28274.Jun 29 2023, 10:07 AM

rohan requested review of this revision.Jun 29 2023, 10:07 AM

rohan added a child revision: D8380: [lib] Instantiate user-surfaced roles, titles, and descriptions.Jun 29 2023, 1:41 PM

rohan added inline comments.Jun 29 2023, 1:51 PM

native/roles/create-roles-screen.react.js
20–22 ↗	(On Diff #28274)	This could probably be `return null`, but I don't think it's really important since it won't be landed as is and will be implemented up the stack

ashoat added a subscriber: • ted.Jul 2 2023, 6:50 PM

ashoat added inline comments.

native/roles/roles-navigator.react.js
43 ↗	(On Diff #28274)	As it stands today, @ted does not have a process down for making sure the copy he produces is okay to handoff to developers. Instead, every dev on the team has to add me as a reviewer to any diffs that have copy. It's a bad process and @ted is working on improving it, but this is what we have now Specifically here, I think buttons and titles in the app should appear as "Create role". @rohan, can you confirm that's how we do it in the app today, and if so updates buttons / titles to match? Make sure you adjust the button too, not just the title that I'm highlighting here. Ideally you adjust the button in the diff that introduces it, but if that's already landed you can do it in this diff too

rohan added inline comments.Jul 3 2023, 8:08 AM

native/roles/roles-navigator.react.js
43 ↗	(On Diff #28274)	I think there's some inconsistency across the app: Invite links: Community creation: Though I know you requested changes to change copy like 'Invite Links' and 'Create Role' to 'Invite links' and 'Create role', so I can match that convention and implement your suggestion

rohan attached a referenced file: F618755: Simulator Screen Shot - iPhone 14 Pro - 2023-07-03 at 11.03.54.png. (Show Details)Jul 3 2023, 8:09 AM

rohan attached a referenced file: F618753: Simulator Screen Shot - iPhone 14 Pro - 2023-07-03 at 11.03.46.png. (Show Details)

headerTitle: 'Create Role' --> headerTitle: 'Create role'

Introduce action: create_role | edit_role since I plan to re-use the screen for editing roles later.

Harbormaster completed remote builds in B20698: Diff 28360.Jul 3 2023, 8:46 AM

Harbormaster completed remote builds in B20699: Diff 28361.Jul 3 2023, 8:55 AM

Thanks Rohan for pointing out those inconsistencies! Would you mind putting up a separate diff to fix up the "Create Community" button too (so it's "Create community")? Figure it should only take a sec

rohan mentioned this in D8427: [native] Change 'Create Community' to 'Create community'.Jul 5 2023, 8:44 AM

In D8379#248093, @ashoat wrote:

Thanks Rohan for pointing out those inconsistencies! Would you mind putting up a separate diff to fix up the "Create Community" button too (so it's "Create community")? Figure it should only take a sec

https://phab.comm.dev/D8427

rohan mentioned this in rCOMMc0a906c779b1: [native] Change 'Create Community' to 'Create community'.Jul 5 2023, 10:46 AM

ginsu accepted this revision.Jul 5 2023, 4:18 PM

This revision is now accepted and ready to land.Jul 5 2023, 4:18 PM

rohan removed a child revision: D8380: [lib] Instantiate user-surfaced roles, titles, and descriptions.Jul 24 2023, 10:53 AM

rohan added a child revision: D8391: [native] Populate the create role screen.

Rebase

Harbormaster completed remote builds in B21404: Diff 29316.Jul 31 2023, 4:05 PM

Closed by commit rCOMM4479b9f88564: [native] Navigate to a screen to create a new role (authored by rohan). · Explain WhyJul 31 2023, 6:14 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM4479b9f88564: [native] Navigate to a screen to create a new role.