Page MenuHomePhabricator

[native] Create a roles navigator to handle the role creation flow
ClosedPublic

Authored by rohan on Jun 27 2023, 8:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 9:22 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:37 PM
Unknown Object (File)
Thu, Nov 7, 10:30 PM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Sep 28 2024, 6:01 PM
Unknown Object (File)
Sep 28 2024, 6:01 PM
Subscribers

Details

Summary

Since the role creation flow will involve more than one screen, I believe it is necessary (or good to have since it's extendable) to have a role-navigator that will handle its related routes. This diff creates the navigator, and the next few diffs in the stack will use this for navigation. I mainly used the invite links navigator & the community creation navigator as inspiration here.

Depends on D8333

ENG-4167

Test Plan

The navigator was tested in the next few diffs as screens for the role creation flow are built out, but locally it works fine and are no issues.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan requested review of this revision.Jun 27 2023, 8:56 AM
atul added inline comments.
native/roles/roles-navigator.react.js
55–57 ↗(On Diff #28182)

Can probably use a self-closing tag here?

This revision is now accepted and ready to land.Jun 27 2023, 9:22 AM
native/roles/roles-navigator.react.js
55–57 ↗(On Diff #28182)

Yeah agreed, I just didn't since I add screens in the next diff and would have to remove the self closing tag anyways