Paths

Table of Contentst

Differential D8335

[native] Create a roles navigator to handle the role creation flow
ClosedPublic
Actions

Authored by rohan on Jun 27 2023, 8:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 17, 12:48 PM

	Unknown Object (File)
	Thu, Nov 14, 2:51 PM

	Unknown Object (File)
	Wed, Nov 13, 10:28 PM

	Unknown Object (File)
	Sun, Nov 10, 9:22 PM

	Unknown Object (File)
	Thu, Nov 7, 10:37 PM

	Unknown Object (File)
	Thu, Nov 7, 10:37 PM

	Unknown Object (File)
	Thu, Nov 7, 10:37 PM

	Unknown Object (File)
	Thu, Nov 7, 10:30 PM

View All 84 Files

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMM27a8c3dce68d: [native] Create a roles navigator to handle the role creation flow

Summary

Since the role creation flow will involve more than one screen, I believe it is necessary (or good to have since it's extendable) to have a role-navigator that will handle its related routes. This diff creates the navigator, and the next few diffs in the stack will use this for navigation. I mainly used the invite links navigator & the community creation navigator as inspiration here.

Depends on D8333

Test Plan

The navigator was tested in the next few diffs as screens for the role creation flow are built out, but locally it works fine and are no issues.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 27 2023, 8:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2023, 8:40 AM

rohan edited the summary of this revision. (Show Details)Jun 27 2023, 8:48 AM

Harbormaster completed remote builds in B20549: Diff 28182.Jun 27 2023, 8:56 AM

rohan requested review of this revision.Jun 27 2023, 8:56 AM

atul accepted this revision.Jun 27 2023, 9:22 AM

atul added inline comments.

native/roles/roles-navigator.react.js
55–57 ↗	(On Diff #28182)	Can probably use a self-closing tag here?

This revision is now accepted and ready to land.Jun 27 2023, 9:22 AM

rohan added inline comments.Jun 27 2023, 9:34 AM

native/roles/roles-navigator.react.js
55–57 ↗	(On Diff #28182)	Yeah agreed, I just didn't since I add screens in the next diff and would have to remove the self closing tag anyways

rohan added a child revision: D8358: [native] Navigate from the community action sheet to the new community roles screen.Jun 28 2023, 9:42 AM

Rebase

Harbormaster completed remote builds in B21401: Diff 29313.Jul 31 2023, 3:26 PM

Closed by commit rCOMM27a8c3dce68d: [native] Create a roles navigator to handle the role creation flow (authored by rohan). · Explain WhyJul 31 2023, 6:14 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM27a8c3dce68d: [native] Create a roles navigator to handle the role creation flow.

Revision Contents
Changeset List

Path

Size

native/

navigation/

root-navigator.react.js

3 lines

5 lines

roles/

roles-navigator.react.js

69 lines

Diff 29374

native/navigation/root-navigator.react.js

Loading...

native/navigation/route-names.js

Loading...

native/roles/roles-navigator.react.js

Loading...