Page MenuHomePhabricator
Differential D8431

[native] Display loading indicator while role creation is in progress
ClosedPublic
Actions

Authored by rohan on Jul 6 2023, 9:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 12:48 PM
Unknown Object (File)
Sat, Nov 23, 8:50 AM
Unknown Object (File)
Sat, Nov 23, 7:15 AM
Unknown Object (File)
Thu, Nov 7, 9:56 PM
Unknown Object (File)
Thu, Nov 7, 9:56 PM
Unknown Object (File)
Thu, Nov 7, 9:56 PM
Unknown Object (File)
Thu, Nov 7, 9:56 PM
Unknown Object (File)
Thu, Nov 7, 9:56 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMMed836b9c759e: [native] Display loading indicator while role creation is in progress
Summary

As another part to improve the UX when creating a role, it'd be good to display a loading indicator if it's particularly slow on production when the 'Create' button is clicked. Specific error
handling will happen later in the stack.

Part of ENG-4178

Depends on D8430

Test Plan

Add a delay in the role creation after dispatch and verified the loading indicator appears

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Jul 6 2023, 9:40 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 6 2023, 9:40 AM
rohan added a child revision: D8432: [keyserver] Add unique key on thread_name in the roles table.Jul 6 2023, 9:46 AM
Harbormaster completed remote builds in B20766: Diff 28442.Jul 6 2023, 9:57 AM
rohan requested review of this revision.Jul 6 2023, 9:57 AM
rohan updated this revision to Diff 28457.Jul 6 2023, 1:47 PM

Rebase

Harbormaster completed remote builds in B20778: Diff 28457.Jul 6 2023, 2:06 PM
rohan updated this revision to Diff 28491.Jul 7 2023, 9:47 AM

Rebase on D8391 and D8420

Harbormaster completed remote builds in B20806: Diff 28491.Jul 7 2023, 10:24 AM
ginsu added a comment.Jul 12 2023, 8:05 PM

Could you post a pic/video of the spinner in the test plan so that we can see what it looks like. Thanks

rohan added a comment.Jul 13 2023, 9:33 AM
In D8431#250317, @ginsu wrote:

Could you post a pic/video of the spinner in the test plan so that we can see what it looks like. Thanks

Yeah sure

ginsu accepted this revision.Jul 13 2023, 9:38 AM

sweet thanks for sharing the video!

native/roles/create-roles-screen.react.js
141–151 ↗(On Diff #28491)

Nit I think using a ternary conditional here would be a bit cleaner but will defer to you

This revision is now accepted and ready to land.Jul 13 2023, 9:38 AM
rohan updated this revision to Diff 29323.Jul 31 2023, 12:01 PM

Rebase

Harbormaster completed remote builds in B21411: Diff 29323.Jul 31 2023, 5:36 PM
Closed by commit rCOMMed836b9c759e: [native] Display loading indicator while role creation is in progress (authored by rohan). · Explain WhyJul 31 2023, 6:15 PM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMMed836b9c759e: [native] Display loading indicator while role creation is in progress.

Revision Contents
Changeset List

PathSize
native/
roles/
38 lines

Diff 29384

View Options

native/roles/create-roles-screen.react.js

Loading...