Page MenuHomePhabricator

[native] Display loading indicator while role creation is in progress
ClosedPublic

Authored by rohan on Jul 6 2023, 9:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 1:20 PM
Unknown Object (File)
Thu, Mar 6, 3:01 AM
Unknown Object (File)
Feb 27 2025, 5:36 PM
Unknown Object (File)
Feb 14 2025, 6:14 PM
Unknown Object (File)
Feb 13 2025, 11:26 AM
Unknown Object (File)
Feb 13 2025, 10:24 AM
Unknown Object (File)
Feb 11 2025, 9:31 AM
Unknown Object (File)
Jan 31 2025, 4:16 PM
Subscribers

Details

Summary

As another part to improve the UX when creating a role, it'd be good to display a loading indicator if it's particularly slow on production when the 'Create' button is clicked. Specific error
handling will happen later in the stack.

Part of ENG-4178

Depends on D8430

Test Plan

Add a delay in the role creation after dispatch and verified the loading indicator appears

Diff Detail

Repository
rCOMM Comm
Branch
create_roles
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

rohan requested review of this revision.Jul 6 2023, 9:57 AM

Could you post a pic/video of the spinner in the test plan so that we can see what it looks like. Thanks

In D8431#250317, @ginsu wrote:

Could you post a pic/video of the spinner in the test plan so that we can see what it looks like. Thanks

Yeah sure

sweet thanks for sharing the video!

native/roles/create-roles-screen.react.js
141–151 ↗(On Diff #28491)

Nit I think using a ternary conditional here would be a bit cleaner but will defer to you

This revision is now accepted and ready to land.Jul 13 2023, 9:38 AM