Paths

Table of Contentst

-
native/roles/
-
roles/
-
create-roles-header-right-button.react.js

Differential D8430

[native] Disable headerRight when the role name is empty
ClosedPublic
Actions

Authored by rohan on Jul 6 2023, 9:28 AM.

Tags

None

Referenced Files

	F4954711: D8430.id28490.diff
	Fri, Mar 21, 10:54 AM

	F4952776: D8430.id.diff
	Thu, Mar 20, 9:48 PM

	Unknown Object (File)
	Wed, Mar 19, 2:39 PM

	Unknown Object (File)
	Mon, Mar 3, 11:22 PM

	Unknown Object (File)
	Feb 14 2025, 6:14 PM

	Unknown Object (File)
	Feb 9 2025, 5:54 PM

	Unknown Object (File)
	Feb 9 2025, 5:54 PM

	Unknown Object (File)
	Feb 3 2025, 4:03 AM

Subscribers

Details

Reviewers

atul
ginsu

Commits

rCOMMeeeb249e17e8: [native] Disable headerRight when the role name is empty

Summary

In an effort to prevent the user from reaching a state that would result in an error (and just a general better UX overall), we should disable the headerRight 'Create' button when the role name is empty. We should allow a user to create a role without any selected permissions because on the keyserver, we add a set of guaranteed permissions anyways, so we won't end up with a case of a role with no permissions.

Error handling for duplicate role names / etc will be done in a later diff.

Part of ENG-4178

Depends on D8428

Test Plan

Verified that the headerRight component is disabled when it should be, and enabled when the role name is non-empty.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jul 6 2023, 9:28 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 6 2023, 9:28 AM

rohan edited the summary of this revision. (Show Details)Jul 6 2023, 9:31 AM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F623533: Simulator Screen Recording - iPhone 14 Pro - 2023-07-06 at 12.25.55.mp4. (Show Details)

rohan added a child revision: D8431: [native] Display loading indicator while role creation is in progress.Jul 6 2023, 9:40 AM

Harbormaster completed remote builds in B20764: Diff 28440.Jul 6 2023, 9:45 AM

rohan requested review of this revision.Jul 6 2023, 9:45 AM

Rebase on D8391 and D8420

Harbormaster completed remote builds in B20805: Diff 28490.Jul 7 2023, 10:15 AM

looks great!

This revision is now accepted and ready to land.Jul 12 2023, 8:01 PM

Rebase

Harbormaster completed remote builds in B21066: Diff 28866.Jul 19 2023, 3:09 PM

Rebase

Harbormaster completed remote builds in B21410: Diff 29322.Jul 31 2023, 5:23 PM

Closed by commit rCOMMeeeb249e17e8: [native] Disable headerRight when the role name is empty (authored by rohan). · Explain WhyJul 31 2023, 6:14 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMeeeb249e17e8: [native] Disable headerRight when the role name is empty.

Revision Contents
Changeset List

Path

Size

native/

roles/

create-roles-header-right-button.react.js

31 lines

Diff 29383

native/roles/create-roles-header-right-button.react.js

	Show First 20 Lines • Show All 274 Lines • ▼ Show 20 Lines		const registerRequestInputValidator = tShape<RegisterRequest>({
	password: tPassword,			password: tPassword,
	calendarQuery: t.maybe(newEntryQueryInputValidator),			calendarQuery: t.maybe(newEntryQueryInputValidator),
	deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),			deviceTokenUpdateRequest: t.maybe(deviceTokenUpdateRequestInputValidator),
	platformDetails: tPlatformDetails,			platformDetails: tPlatformDetails,
	// We include `primaryIdentityPublicKey` to avoid breaking			// We include `primaryIdentityPublicKey` to avoid breaking
	// old clients, but we no longer do anything with it.			// old clients, but we no longer do anything with it.
	primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),			primaryIdentityPublicKey: t.maybe(tRegex(primaryIdentityPublicKeyRegex)),
	signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),			signedIdentityKeysBlob: t.maybe(signedIdentityKeysBlobValidator),
				initialNotificationsEncryptedMessage: t.maybe(t.String),
	});			});

	export const registerResponseValidator: TInterface<RegisterResponse> =			export const registerResponseValidator: TInterface<RegisterResponse> =
	tShape<RegisterResponse>({			tShape<RegisterResponse>({
	id: t.String,			id: t.String,
	rawMessageInfos: t.list(rawMessageInfoValidator),			rawMessageInfos: t.list(rawMessageInfoValidator),
	currentUserInfo: t.union([			currentUserInfo: t.union([
	oldLoggedInUserInfoValidator,			oldLoggedInUserInfoValidator,
	▲ Show 20 Lines • Show All 536 Lines • Show Last 20 Lines