The button is visible only when a link is present.
Clicking the button results in alert being shown where a user is asked to confirm the action.
Confirming results in the link being disabled.
Depends on D7907
Details
Details
- Reviewers
bartek kamil inka - Commits
- rCOMM4fd6b754e127: [native] Introduce disable link button
Check if the button appears only when a link is present.
Check if clicking it results in an alert.
Check if canceling doesn't disable the link.
Check if confirming disables the link.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/themes/colors.js | ||
|---|---|---|
| 140 ↗ | (On Diff #26775) | Hey @tomek! I took a look at our color.js file, and did notice that errorDark50 isn't used in any other components yet. I know the designs are using errorDark50, but thinking about it, it may be better to use vibrantRedButton: designSystemColors.errorPrimary My only concern with the primary color was how bright it may be and attention grabbing, but we already have components using the primary in our system. What do you think? |
| native/themes/colors.js | ||
|---|---|---|
| 140 ↗ | (On Diff #26775) | For me there's a value in distinguishing between error and destructive actions. So having different colors for them makes sense. But merging these also is an option. I've checked how it looks like with an alternative color. It's indeed brighter. But compared to the older color, that button looks a little bit like it's disabled. (but only in comparison)  |
| native/invite-links/manage-public-link-screen.react.js | ||
|---|---|---|
| 125–131 ↗ | (On Diff #26886) | Wondering how this button looks in light mode |
| native/invite-links/manage-public-link-screen.react.js | ||
|---|---|---|
| 103–105 ↗ | (On Diff #26886) | Does this message look well in native alert box? It's pretty long |