Page MenuHomePhabricator
Differential D7727

[lib] Allow calling endpoints with empty payload
ClosedPublic
Actions

Authored by tomek on May 5 2023, 8:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 2:17 AM
Unknown Object (File)
Thu, Apr 3, 12:32 PM
Unknown Object (File)
Mon, Mar 17, 1:26 PM
Unknown Object (File)
Mon, Mar 17, 1:26 PM
Unknown Object (File)
Mon, Mar 17, 1:26 PM
Unknown Object (File)
Mon, Mar 17, 1:26 PM
Unknown Object (File)
Mon, Mar 17, 1:25 PM
Unknown Object (File)
Mon, Mar 17, 1:14 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload
Summary

At this point socket validation fails for requests without a payload. A new endpoint that was introduced in D7726 doesn't have a payload and we should allow sending a request to it.

Test Plan

Check if sending a request passes validation.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.May 5 2023, 8:39 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 5 2023, 8:39 AM
tomek added a child revision: D7728: [lib] Add client side boilerplate for the new endpoint.May 5 2023, 8:41 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2023, 8:55 AM
Harbormaster failed remote builds in B19071: Diff 26119!
tomek updated this revision to Diff 26166.May 8 2023, 3:13 AM

Rebase

Harbormaster completed remote builds in B19112: Diff 26166.May 8 2023, 3:30 AM
tomek requested review of this revision.May 8 2023, 3:30 AM
ashoat added a comment.May 8 2023, 6:44 AM

Thanks for making this fix. siweNonceResponder also doesn't have an input

bartek accepted this revision.May 8 2023, 7:28 AM
This revision is now accepted and ready to land.May 8 2023, 7:28 AM
tomek removed a parent revision: D7726: [keyserver] Create an endpoint returning primary invite links.May 10 2023, 2:59 AM
tomek removed a child revision: D7728: [lib] Add client side boilerplate for the new endpoint.
tomek added a child revision: D7726: [keyserver] Create an endpoint returning primary invite links.
tomek edited the summary of this revision. (Show Details)May 10 2023, 3:05 AM
tomek updated this revision to Diff 26322.May 10 2023, 3:06 AM

Rebase

Harbormaster completed remote builds in B19223: Diff 26322.May 10 2023, 3:23 AM
Closed by commit rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload (authored by tomek). · Explain WhyMay 10 2023, 5:34 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
2 lines
lib/
types/
2 lines

Diff 26338

View Options

keyserver/src/socket/socket.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

lib/types/endpoints.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines