Paths

Table of Contentst

[lib] Allow calling endpoints with empty payload
ClosedPublic
Actions

Authored by tomek on May 5 2023, 8:39 AM.

Details

Reviewers

bartek
kamil
inka

Commits

rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload

Summary

At this point socket validation fails for requests without a payload. A new endpoint that was introduced in D7726 doesn't have a payload and we should allow sending a request to it.

Test Plan

Check if sending a request passes validation.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 5 2023, 8:39 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 5 2023, 8:39 AM

tomek added a child revision: D7728: [lib] Add client side boilerplate for the new endpoint.May 5 2023, 8:41 AM

Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2023, 8:55 AM

Harbormaster failed remote builds in B19071: Diff 26119!

Rebase

Harbormaster completed remote builds in B19112: Diff 26166.May 8 2023, 3:30 AM

tomek requested review of this revision.May 8 2023, 3:30 AM

Thanks for making this fix. siweNonceResponder also doesn't have an input

bartek accepted this revision.May 8 2023, 7:28 AM

This revision is now accepted and ready to land.May 8 2023, 7:28 AM

tomek removed a parent revision: D7726: [keyserver] Create an endpoint returning primary invite links.May 10 2023, 2:59 AM

tomek removed a child revision: D7728: [lib] Add client side boilerplate for the new endpoint.

tomek added a child revision: D7726: [keyserver] Create an endpoint returning primary invite links.

tomek edited the summary of this revision. (Show Details)May 10 2023, 3:05 AM

Rebase

Harbormaster completed remote builds in B19223: Diff 26322.May 10 2023, 3:23 AM

Closed by commit rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload (authored by tomek). · Explain WhyMay 10 2023, 5:34 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMee8762ce834c: [lib] Allow calling endpoints with empty payload.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

socket.js

2 lines

lib/

types/

endpoints.js

2 lines

Diff 26338

View Options

keyserver/src/socket/socket.js