Page MenuHomePhabricator
Differential D7941

[keyserver] Convert flag to a boolean
ClosedPublic
Actions

Authored by tomek on May 23 2023, 6:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Wed, Mar 26, 11:49 AM
Unknown Object (File)
Mon, Mar 24, 6:50 AM
Unknown Object (File)
Thu, Mar 20, 3:50 PM
Unknown Object (File)
Thu, Mar 6, 8:59 PM
Unknown Object (File)
Feb 25 2025, 7:18 PM
Unknown Object (File)
Feb 13 2025, 5:40 PM
View All 96 Files
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
michal
Commits
rCOMM4f0eb1d7c7a6: [keyserver] Convert flag to a boolean
Summary

Instead of returning a boolean we were returning a number. Everything worked correctly, because 0 is falsy. Only recently introduced output validator made the bug evident.

Test Plan

Check if fetching invite links works.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
2 lines

Diff 26962

View Options

keyserver/src/fetchers/link-fetchers.js

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines SQL`
CREATE TABLE sessions ( CREATE TABLE sessions (
id bigint(20) NOT NULL, id bigint(20) NOT NULL,
user bigint(20) NOT NULL, user bigint(20) NOT NULL,
cookie bigint(20) NOT NULL, cookie bigint(20) NOT NULL,
query json NOT NULL, query json NOT NULL,
creation_time bigint(20) NOT NULL, creation_time bigint(20) NOT NULL,
last_update bigint(20) NOT NULL, last_update bigint(20) NOT NULL,
last_validated bigint(20) NOT NULL last_validated bigint(20) NOT NULL,
public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1; ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
CREATE TABLE threads ( CREATE TABLE threads (
id bigint(20) NOT NULL, id bigint(20) NOT NULL,
type tinyint(3) NOT NULL, type tinyint(3) NOT NULL,
name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL, name varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
description mediumtext COLLATE utf8mb4_bin, description mediumtext COLLATE utf8mb4_bin,
parent_thread_id bigint(20) DEFAULT NULL, parent_thread_id bigint(20) DEFAULT NULL,
Show All 30 Lines SQL`
secret varchar(255) NOT NULL, secret varchar(255) NOT NULL,
creation_time bigint(20) NOT NULL, creation_time bigint(20) NOT NULL,
extra json DEFAULT NULL extra json DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8; ) ENGINE=InnoDB DEFAULT CHARSET=utf8;
CREATE TABLE users ( CREATE TABLE users (
id bigint(20) NOT NULL, id bigint(20) NOT NULL,
username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL, username varchar(${usernameMaxLength}) COLLATE utf8mb4_bin NOT NULL,
hash char(60) COLLATE utf8mb4_bin DEFAULT NULL, hash char(60) COLLATE utf8mb4_bin NOT NULL,
avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL, avatar varchar(191) COLLATE utf8mb4_bin DEFAULT NULL,
creation_time bigint(20) NOT NULL creation_time bigint(20) NOT NULL,
public_key char(116) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin; ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin;
CREATE TABLE relationships_undirected ( CREATE TABLE relationships_undirected (
user1 bigint(20) NOT NULL, user1 bigint(20) NOT NULL,
user2 bigint(20) NOT NULL, user2 bigint(20) NOT NULL,
status tinyint(1) UNSIGNED NOT NULL status tinyint(1) UNSIGNED NOT NULL
) ENGINE=InnoDB DEFAULT CHARSET=latin1; ) ENGINE=InnoDB DEFAULT CHARSET=latin1;
▲ Show 20 Lines • Show All 85 Lines • ▼ Show 20 Lines SQL`
ADD KEY entry (entry); ADD KEY entry (entry);
ALTER TABLE roles ALTER TABLE roles
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD KEY thread (thread); ADD KEY thread (thread);
ALTER TABLE sessions ALTER TABLE sessions
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD KEY user (user); ADD KEY user (user),
ADD UNIQUE INDEX public_key (public_key);
ALTER TABLE threads ALTER TABLE threads
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD INDEX parent_thread_id (parent_thread_id), ADD INDEX parent_thread_id (parent_thread_id),
ADD INDEX containing_thread_id (containing_thread_id), ADD INDEX containing_thread_id (containing_thread_id),
ADD INDEX community (community); ADD INDEX community (community);
ALTER TABLE updates ALTER TABLE updates
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD INDEX user_time (user,time), ADD INDEX user_time (user,time),
ADD INDEX target_time (target, time), ADD INDEX target_time (target, time),
ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time), ADD INDEX user_key_target_type_time (user, \`key\`, target, type, time),
ADD INDEX user_key_type_time (user, \`key\`, type, time), ADD INDEX user_key_type_time (user, \`key\`, type, time),
ADD INDEX user_key_time (user, \`key\`, time); ADD INDEX user_key_time (user, \`key\`, time);
ALTER TABLE uploads ALTER TABLE uploads
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD INDEX container (container); ADD INDEX container (container);
ALTER TABLE users ALTER TABLE users
ADD PRIMARY KEY (id), ADD PRIMARY KEY (id),
ADD UNIQUE KEY username (username); ADD UNIQUE KEY username (username),
ADD UNIQUE INDEX public_key (public_key);
ALTER TABLE relationships_undirected ALTER TABLE relationships_undirected
ADD UNIQUE KEY user1_user2 (user1,user2), ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1); ADD UNIQUE KEY user2_user1 (user2,user1);
ALTER TABLE relationships_directed ALTER TABLE relationships_directed
ADD UNIQUE KEY user1_user2 (user1,user2), ADD UNIQUE KEY user1_user2 (user1,user2),
ADD UNIQUE KEY user2_user1 (user2,user1); ADD UNIQUE KEY user2_user1 (user2,user1);
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines