Page MenuHomePhabricator

[lib] Allow calling link-disabling endpoint

Authored by tomek on Mon, May 22, 6:29 AM.
Referenced Files
Unknown Object (File)
Thu, Jun 1, 6:34 PM
Unknown Object (File)
Mon, May 29, 7:34 PM



The reducer deletes an entry in the store. In the future we will have to do more here, as not only public links can be disabled.

Depends on D7906

Test Plan

Confirm disabling a link and check if it was deleted, e.g. by verifying that disable link button disappears.

Diff Detail

rCOMM Comm
Lint Not Applicable
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Mon, May 22, 6:47 AM

I think the differential name is not complete and confusing a bit

44 ↗(On Diff #26774)

I would move currentPrimaryLink?.name === condition to if upper, and avoid modifying the state if it's falsy

This revision is now accepted and ready to land.Mon, May 22, 10:44 AM
In D7907#234718, @kamil wrote:

I think the differential name is not complete and confusing a bit

It seems so... not sure what happened

tomek retitled this revision from [lib] Add reducer and endpoint calling code to [lib] Allow calling link-disabling endpoint.Tue, May 23, 6:52 AM

Make reducer more efficient

This revision was automatically updated to reflect the committed changes.