In this modal we display a link and allow user to copy it.
Depends on D7728
Paths
| Differential D7730 Authored by tomek on May 5 2023, 8:51 AM.
Tags None Referenced Files
Details Summary In this modal we display a link and allow user to copy it. Depends on D7728 Test Plan Display a modal and click copy button - a pasteboard should contain the link.
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptMay 5 2023, 8:51 AM2023-05-05 08:51:34 (UTC-7) tomek edited the summary of this revision. (Show Details)May 5 2023, 9:02 AM2023-05-05 09:02:47 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.May 5 2023, 9:04 AM2023-05-05 09:04:59 (UTC-7) Harbormaster completed remote builds in B19118: Diff 26172.May 8 2023, 4:20 AM2023-05-08 04:20:30 (UTC-7)
tomek edited the summary of this revision. (Show Details)May 10 2023, 7:19 AM2023-05-10 07:19:44 (UTC-7) Harbormaster failed remote builds in B19246: Diff 26348!May 10 2023, 7:30 AM2023-05-10 07:30:46 (UTC-7) Harbormaster failed remote builds in B19247: Diff 26349!May 10 2023, 7:34 AM2023-05-10 07:34:45 (UTC-7) Harbormaster completed remote builds in B19326: Diff 26440.May 15 2023, 3:28 AM2023-05-15 03:28:42 (UTC-7) Herald added a subscriber: • ted. · View Herald TranscriptMay 16 2023, 4:10 AM2023-05-16 04:10:25 (UTC-7) Harbormaster completed remote builds in B19380: Diff 26515.May 16 2023, 4:27 AM2023-05-16 04:27:51 (UTC-7) tomek edited the summary of this revision. (Show Details)May 16 2023, 8:39 AM2023-05-16 08:39:54 (UTC-7) Harbormaster completed remote builds in B19404: Diff 26547.May 16 2023, 8:54 AM2023-05-16 08:54:46 (UTC-7)
tomek edited parent revisions, added: D7877: [lib] Create a store in redux for the invite links; removed: D7728: [lib] Add client side boilerplate for the new endpoint.May 19 2023, 9:47 AM2023-05-19 09:47:57 (UTC-7) Harbormaster completed remote builds in B19511: Diff 26676.May 19 2023, 10:05 AM2023-05-19 10:05:31 (UTC-7)
Comment Actions Looks good, but would love to see an opinion from someone more experienced in @react-navigation (cc. @inka) This revision is now accepted and ready to land.May 23 2023, 5:23 AM2023-05-23 05:23:16 (UTC-7)
Harbormaster completed remote builds in B19664: Diff 26872.May 23 2023, 5:45 AM2023-05-23 05:45:20 (UTC-7) Comment Actions Looks good
Comment Actions
Can you create a DES task and assign it to Ted, to make sure we follow up after he is back? Comment Actions
Sure, I've created https://linear.app/comm/issue/DES-90/try-to-use-existing-colors-on-view-invite-links-screen for it. Closed by commit rCOMMd33be322bf98: [native] Create a modal where invite links are displayed (authored by tomek). · Explain WhyMay 24 2023, 4:23 AM2023-05-24 04:23:07 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26964 native/invite-links/invite-links-navigator.react.js
native/invite-links/view-invite-links-header-left-button.react.js
native/invite-links/view-invite-links-header-title.react.js
native/invite-links/view-invite-links-screen.react.js
|