Details

Reviewers

kamil
inka
tomek

Commits

rCOMM8a48d2c36145: [lib] Introduce raw message info validators

Summary

Add validators for RawMessageInfo and inner types and tests for each message type. In tests all message examples are taken from the app except for change role, unsupported, edit message and pin message which I wrote manually.

Depends on D7566

Test Plan

Run yarn jest

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Apr 21 2023, 8:08 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 8:08 AM

michal mentioned this in D7569: [lib] Introduce raw thread info validators.Apr 21 2023, 8:12 AM

Harbormaster completed remote builds in B18653: Diff 25544.Apr 21 2023, 8:25 AM

michal requested review of this revision.Apr 21 2023, 8:25 AM

michal added a child revision: D7569: [lib] Introduce raw thread info validators.Apr 25 2023, 6:21 AM

tomek accepted this revision.Apr 25 2023, 7:30 AM

tomek added inline comments.

lib/types/validation.test.js
317–340 ↗	(On Diff #25544)	Wondering if it might be beneficial to create a `validator` field in message spec
350–352 ↗	(On Diff #25544)	Should we add more descriptive error message? `true !== false` won't be too useful when debugging.

This revision is now accepted and ready to land.Apr 25 2023, 7:30 AM

Updated test descriptions. Added validator to message spec in another diff.

michal mentioned this in D7655: [lib] Add validator to the message spec.Apr 27 2023, 6:28 AM

michal added a child revision: D7655: [lib] Add validator to the message spec.Apr 27 2023, 6:29 AM

Harbormaster completed remote builds in B18854: Diff 25823.Apr 27 2023, 6:45 AM

Rebase

Harbormaster completed remote builds in B19026: Diff 26057.May 4 2023, 3:25 AM

Also convert roles

Harbormaster completed remote builds in B19065: Diff 26099.May 5 2023, 4:23 AM

Closed by commit rCOMM8a48d2c36145: [lib] Introduce raw message info validators (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMMce72e5f71c1f: [lib] Add validator to the message spec.

Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMMf0de5dc1e446: [lib] Introduce raw thread info validators.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM8a48d2c36145: [lib] Introduce raw message info validators.

[lib] Introduce raw message info validators
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 26109

lib/types/message-types.js

lib/types/messages/add-members.js

lib/types/messages/change-role.js

lib/types/messages/change-settings.js

lib/types/messages/create-entry.js

lib/types/messages/create-sidebar.js

lib/types/messages/create-subthread.js

lib/types/messages/create-thread.js

lib/types/messages/delete-entry.js

lib/types/messages/edit-entry.js

lib/types/messages/edit.js

lib/types/messages/images.js

lib/types/messages/join-thread.js

lib/types/messages/leave-thread.js

lib/types/messages/media.js

lib/types/messages/reaction.js

lib/types/messages/remove-members.js

lib/types/messages/restore-entry.js

lib/types/messages/text.js

lib/types/messages/toggle-pin.js

lib/types/messages/unsupported.js

lib/types/messages/update-relationship.js

lib/types/validation.test.js

[lib] Introduce raw message info validatorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26109

lib/types/message-types.js

lib/types/messages/add-members.js

lib/types/messages/change-role.js

lib/types/messages/change-settings.js

lib/types/messages/create-entry.js

lib/types/messages/create-sidebar.js

lib/types/messages/create-subthread.js

lib/types/messages/create-thread.js

lib/types/messages/delete-entry.js

lib/types/messages/edit-entry.js

lib/types/messages/edit.js

lib/types/messages/images.js

lib/types/messages/join-thread.js

lib/types/messages/leave-thread.js

lib/types/messages/media.js

lib/types/messages/reaction.js

lib/types/messages/remove-members.js

lib/types/messages/restore-entry.js

lib/types/messages/text.js

lib/types/messages/toggle-pin.js

lib/types/messages/unsupported.js

lib/types/messages/update-relationship.js

lib/types/validation.test.js

[lib] Introduce raw message info validators
ClosedPublic
Actions

Revision Contents
Changeset List