Paths

Table of Contentst

Differential D7487

[keyserver] Add password sanitization tests
ClosedPublic
Actions

Authored by michal on Apr 18 2023, 8:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 14, 3:56 PM

	Unknown Object (File)
	Fri, Apr 12, 4:26 PM

	Unknown Object (File)
	Wed, Apr 10, 10:12 AM

	Unknown Object (File)
	Fri, Apr 5, 5:31 AM

	Unknown Object (File)
	Fri, Apr 5, 5:31 AM

	Unknown Object (File)
	Fri, Apr 5, 5:31 AM

	Unknown Object (File)
	Fri, Apr 5, 5:30 AM

	Unknown Object (File)
	Fri, Apr 5, 5:18 AM

View All 71 Files

Subscribers

Details

Reviewers

kamil
inka
tomek

Commits

rCOMMb533fd513aa2: [keyserver] Add password sanitization tests

Summary

The sanitizeInput function will be abstracted by a general function implementing a visitor pattern (which we will also use for the server_id<->client_id conversion function) in the later diffs. This diff adds some tests so we can check that the behaviour doesn't change.

Test Plan

Run yarn jest

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Apr 18 2023, 8:13 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 18 2023, 8:13 AM

michal added a parent revision: D7467: [keyserver/lib] Improve `tcomb` types.Apr 18 2023, 8:13 AM

Harbormaster completed remote builds in B18453: Diff 25271.Apr 18 2023, 8:31 AM

michal requested review of this revision.Apr 18 2023, 8:31 AM

michal added a child revision: D7488: [keyserver] Introduce convertObject function.Apr 18 2023, 8:34 AM

ashoat added inline comments.Apr 18 2023, 9:22 AM

keyserver/src/utils/validation-utils.js
64 ↗	(On Diff #25271)	Thanks for getting rid of the `*` Is it possible to type this any better?

ashoat added inline comments.Apr 18 2023, 9:29 AM

keyserver/src/utils/validation-utils.js
64 ↗	(On Diff #25271)	Ignore this comment, types are improved in D7488

tomek accepted this revision.Apr 21 2023, 1:39 AM

This revision is now accepted and ready to land.Apr 21 2023, 1:39 AM

Rebase

Harbormaster completed remote builds in B19021: Diff 26052.May 4 2023, 3:20 AM

Closed by commit rCOMMb533fd513aa2: [keyserver] Add password sanitization tests (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMb533fd513aa2: [keyserver] Add password sanitization tests.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

validation-utils.js

5 lines

validation-utils.test.js

27 lines

Diff 26104

keyserver/src/utils/validation-utils.js

Loading...

keyserver/src/utils/validation-utils.test.js

Loading...