Page MenuHomePhabricator
Differential D7750

[keyserver] Convert websocket input
ClosedPublic
Actions

Authored by michal on May 9 2023, 1:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 8:32 AM
Unknown Object (File)
Thu, Apr 11, 6:11 AM
Unknown Object (File)
Fri, Apr 5, 4:59 AM
Unknown Object (File)
Fri, Apr 5, 4:59 AM
Unknown Object (File)
Fri, Apr 5, 4:58 AM
Unknown Object (File)
Fri, Apr 5, 4:38 AM
Unknown Object (File)
Mar 1 2024, 6:46 AM
Unknown Object (File)
Feb 19 2024, 4:05 PM
View All 23 Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
Commits
rCOMMd5d2636c589e: [keyserver] Convert websocket input
Summary

Changes the websocket validation logic to convert the ids (after enabling the flag).

Depends D7749

Test Plan

Check if any of the input validators needed to be updated to mark the IDs (they were all using validators which have been marked in previous diffs).
Check if web and ios app work fine, and there aren't any errors.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.May 9 2023, 1:43 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 9 2023, 1:43 AM
Harbormaster completed remote builds in B19161: Diff 26242.May 9 2023, 2:01 AM
michal requested review of this revision.May 9 2023, 2:01 AM
tomek requested changes to this revision.May 10 2023, 1:09 AM

Are you sure this is correct? Shouldn't we also convert a response from the server?

This revision now requires changes to proceed.May 10 2023, 1:09 AM
michal added a parent revision: D7749: [keyserver] Validate websocket output.May 10 2023, 6:54 AM
michal requested review of this revision.May 10 2023, 6:57 AM

Are you sure this is correct? Shouldn't we also convert a response from the server?

If I'm not misunderstanding, the responses are validated in D7749.

michal added a child revision: D7783: [lib] Split thread-types.May 11 2023, 2:14 AM
tomek accepted this revision.May 15 2023, 2:04 AM
This revision is now accepted and ready to land.May 15 2023, 2:04 AM
Closed by commit rCOMMd5d2636c589e: [keyserver] Convert websocket input (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMd5d2636c589e: [keyserver] Convert websocket input.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
9 lines

Diff 26456

View Options

keyserver/src/socket/socket.js

Loading...