[keyserver] Start validating responders output
ClosedPublic
Actions

Authored by michal on May 4 2023, 7:51 AM.

Details

Reviewers

tomek
kamil

Commits

rCOMM29cd9a0322a7: [keyserver] Start validating responders output

Summary

Use the validators and the validateOutput function introduced in the previous diff in the api responders. The id schema conversion is behind the flag for now, but the outputs are still validated.

Depends on D7711

Test Plan

Test web and ios emulator if all outputs are validated correctly and no server error is thrown.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.May 4 2023, 7:51 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 4 2023, 7:51 AM

michal retitled this revision from [keyserver] Convert responders output to [keyserver] Start validating responders output.May 4 2023, 7:53 AM

michal edited the summary of this revision. (Show Details)

michal added a child revision: D7713: [keyserver] Mark ids in input validators.May 4 2023, 7:55 AM

michal added inline comments.May 4 2023, 8:07 AM

keyserver/src/responders/user-responders.js
703–711 ↗	(On Diff #26070)	This is done in this diff, because `updateUserAvatarResponder` was modified while my stack was up and I would have to reorder and modify diffs for to add it to the existing diffs. The changes are small so I thought that I will just add them here.