We will also need to convert ids in the input, so this diff marks the ids for conversion inside existing input validators. tID should behave the same as t.String so there should be no runtime difference.
Depends on D7712
Details
Details
- Reviewers
kamil tomek - Commits
- rCOMM5c48e173ee1e: [keyserver] Mark ids in input validators
Went through all existing input validators and sub-validators and changed t.String to tID in places where ids should be updated.
Test if the web and mobile app still work.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
In diffs like this a test plan has to contain a description of what you have done to make sure that all the necessary changes were made. Without this it is impossible to verify that all the changes are there.
Comment Actions
- Updated the test plan
- Also converted role ids. This required the conversion logic to handle tComb refinements, so I added that and tests
| keyserver/src/utils/validation-utils.test.js | ||
|---|---|---|
| 110 ↗ | (On Diff #26151) | Role value can be -1 - should we add a test for it? |
| keyserver/src/utils/validation-utils.test.js | ||
|---|---|---|
| 110 ↗ | (On Diff #26151) | I have tests with -1 role id in responder-validators.test.js |