We will also need to convert ids in the input, so this diff marks the ids for conversion inside existing input validators. tID should behave the same as t.String so there should be no runtime difference.
Depends on D7712
Paths
| Differential D7713 Authored by michal on May 4 2023, 7:55 AM.
Details
Summary We will also need to convert ids in the input, so this diff marks the ids for conversion inside existing input validators. tID should behave the same as t.String so there should be no runtime difference. Depends on D7712 Test Plan Went through all existing input validators and sub-validators and changed t.String to tID in places where ids should be updated.
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptMay 4 2023, 7:55 AM2023-05-04 07:55:31 (UTC-7) Harbormaster completed remote builds in B19039: Diff 26071.May 4 2023, 8:12 AM2023-05-04 08:12:34 (UTC-7) michal added a child revision: D7714: [keyserver] Introduce input id conversion.May 4 2023, 8:21 AM2023-05-04 08:21:47 (UTC-7) Comment Actions In diffs like this a test plan has to contain a description of what you have done to make sure that all the necessary changes were made. Without this it is impossible to verify that all the changes are there. This revision now requires changes to proceed.May 5 2023, 12:47 AM2023-05-05 00:47:40 (UTC-7) Comment Actions
michal edited the test plan for this revision. (Show Details)May 8 2023, 1:43 AM2023-05-08 01:43:44 (UTC-7) Harbormaster completed remote builds in B19101: Diff 26151.May 8 2023, 1:59 AM2023-05-08 01:59:24 (UTC-7) This revision is now accepted and ready to land.May 8 2023, 3:01 AM2023-05-08 03:01:06 (UTC-7)
Closed by commit rCOMM5c48e173ee1e: [keyserver] Mark ids in input validators (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM2023-05-15 05:00:14 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26453 keyserver/src/responders/activity-responders.js
keyserver/src/responders/entry-responders.js
keyserver/src/responders/message-report-responder.js
keyserver/src/responders/message-responders.js
|