Introduce remaining api responder validators and tests for them.
Depends on D7709
Paths
| Differential D7710 Authored by michal on May 4 2023, 3:44 AM.
Details Summary Introduce remaining api responder validators and tests for them. Depends on D7709 Test Plan yarn jest
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptMay 4 2023, 3:44 AM2023-05-04 03:44:12 (UTC-7) michal added a child revision: D7711: [keyserver] Introduce validateOutput function.May 4 2023, 3:56 AM2023-05-04 03:56:06 (UTC-7) Harbormaster completed remote builds in B19034: Diff 26065.May 4 2023, 4:01 AM2023-05-04 04:01:33 (UTC-7)
tomek added inline comments. This revision now requires changes to proceed.May 5 2023, 12:18 AM2023-05-05 00:18:36 (UTC-7) Comment Actions I've talked with @ashoat about report ids, and in the future, we probably will send them to some centralized server, so we don't need to convert ids or payloads. Currently the ids aren't used anywhere on the client side (except for being displayed in an alert once). Harbormaster completed remote builds in B19068: Diff 26102.May 5 2023, 4:33 AM2023-05-05 04:33:04 (UTC-7) Comment Actions
More context on this in ENG-2102
Since the reports are only for devs to examine, it's not very important for us to worry about the IDs inside the report. As for the IDs that represent reports, these are mostly only used on the server side, with the exception of one inactive endpoint. This revision is now accepted and ready to land.May 5 2023, 7:47 AM2023-05-05 07:47:54 (UTC-7) Closed by commit rCOMMfe70bcc2d940: [keyserver] Introduce report, message and thread responder validators (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM2023-05-15 05:00:04 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 26450 keyserver/src/responders/message-responders.js
keyserver/src/responders/report-responders.js
keyserver/src/responders/responder-validators.test.js
keyserver/src/responders/thread-responders.js
lib/types/report-types.js
|