Page MenuHomePhabricator
Differential D7885

[native] Add a link to manage public link screen
ClosedPublic
Actions

Authored by tomek on Fri, May 19, 10:18 AM.
Tags
None
Referenced Files
F570629: D7885.id26688.diff
Sat, Jun 3, 1:43 PM
F570369: D7885.id26973.diff
Sat, Jun 3, 1:41 AM
Unknown Object (File)
Fri, Jun 2, 12:43 AM
Unknown Object (File)
Wed, May 31, 1:15 PM
F554348: edit_link_link.png
Tue, May 23, 6:29 AM
Unknown Object (File)
Fri, May 19, 10:43 AM
Subscribers
ashoat
atul

Details

Reviewers
bartek
kamil
inka
Commits
rCOMMe6891cd75195: [native] Add a link to manage public link screen
Summary

The link is visible only to admin users.

edit_link_link.png (2×1 px, 124 KB)

Depends on D7884

Test Plan

Check if a link is visible only to admin users and if clicking it navigates the user to manage links screen.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Fri, May 19, 10:18 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFri, May 19, 10:18 AM
Harbormaster completed remote builds in B19521: Diff 26688.Fri, May 19, 10:35 AM
tomek requested review of this revision.Fri, May 19, 10:35 AM
tomek added a child revision: D7906: [keyserver] Create an endpoint that allows disabling links.Mon, May 22, 6:25 AM
kamil accepted this revision.Mon, May 22, 9:52 AM

Can you share a screenshot of how this looks like?

native/invite-links/view-invite-links-screen.react.js
17–18 ↗(On Diff #26688)

can be merged

59 ↗(On Diff #26688)

maybe it'll be better to call this once and store result in variable instead of calling twice

This revision is now accepted and ready to land.Mon, May 22, 9:52 AM
tomek edited the summary of this revision. (Show Details)Tue, May 23, 6:29 AM
tomek updated this revision to Diff 26881.Tue, May 23, 6:36 AM

Minor fixes

tomek added a comment.Tue, May 23, 6:37 AM
In D7885#234677, @kamil wrote:

Can you share a screenshot of how this looks like?

Added to a summary.

Harbormaster completed remote builds in B19673: Diff 26881.Tue, May 23, 6:54 AM
tomek mentioned this in D7730: [native] Create a modal where invite links are displayed.Tue, May 23, 7:20 AM
Closed by commit rCOMMe6891cd75195: [native] Add a link to manage public link screen (authored by tomek). · Explain WhyWed, May 24, 4:23 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMe6891cd75195: [native] Add a link to manage public link screen.

Revision Contents
Changeset List

PathSize
native/
invite-links/
52 lines

Diff 26973

View Options

native/invite-links/view-invite-links-screen.react.js

Loading...