Page MenuHomePhabricator
Differential D7807

[keyserver] Validate link responders
ClosedPublic
Actions

Authored by michal on May 15 2023, 3:55 AM.
Tags
None
Referenced Files
F5082713: D7807.id.diff
Sat, Mar 29, 9:25 AM
Unknown Object (File)
Tue, Mar 25, 11:47 AM
Unknown Object (File)
Tue, Mar 25, 11:46 AM
Unknown Object (File)
Tue, Mar 25, 11:46 AM
Unknown Object (File)
Tue, Mar 25, 11:46 AM
Unknown Object (File)
Fri, Mar 21, 11:18 PM
Unknown Object (File)
Wed, Mar 19, 10:00 PM
Unknown Object (File)
Mon, Mar 17, 12:55 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
Commits
rCOMM72310720eb50: [keyserver] Validate link responders
Summary

Add validators and validate link responders, add tests.

Depends on D7806

Test Plan

yarn jest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.May 15 2023, 3:55 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 15 2023, 3:55 AM
michal added a child revision: D7808: [keyserver] Convert upload responders.May 15 2023, 3:57 AM
Harbormaster completed remote builds in B19333: Diff 26447.May 15 2023, 4:12 AM
michal requested review of this revision.May 15 2023, 4:12 AM
tomek accepted this revision.May 16 2023, 3:18 AM
This revision is now accepted and ready to land.May 16 2023, 3:18 AM
Closed by commit rCOMM72310720eb50: [keyserver] Validate link responders (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 17 2023, 1:29 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM72310720eb50: [keyserver] Validate link responders.
tomek added a comment.EditedMay 17 2023, 1:35 AM

@michal are you planning to write validators for fetchPrimaryInviteLinksResponder? I guess it should be done during the rebase.

michal added a comment.May 17 2023, 1:55 AM

Sorry, I should have noticed that during rebase, I will put up a diff with the validators.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
39 lines
15 lines

Diff 26573

View Options

keyserver/src/responders/link-responders.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };
View Options

keyserver/src/responders/responder-validators.test.js

// @flow // @flow
import t, { type TInterface } from 'tcomb'; import t, { type TInterface } from 'tcomb';
import type { import type {
UserSearchRequest, UserSearchRequest,
UserSearchResult, UserSearchResult,
ExactUserSearchRequest,
ExactUserSearchResult,
} from 'lib/types/search-types.js'; } from 'lib/types/search-types.js';
import { globalAccountUserInfoValidator } from 'lib/types/user-types.js'; import { globalAccountUserInfoValidator } from 'lib/types/user-types.js';
import { tShape } from 'lib/utils/validation-utils.js'; import { tShape } from 'lib/utils/validation-utils.js';
import { searchForUsers } from '../search/users.js'; import { searchForUsers, searchForUser } from '../search/users.js';
import type { Viewer } from '../session/viewer.js'; import type { Viewer } from '../session/viewer.js';
import { validateInput, validateOutput } from '../utils/validation-utils.js'; import { validateInput, validateOutput } from '../utils/validation-utils.js';
const userSearchRequestInputValidator = tShape<UserSearchRequest>({ const userSearchRequestInputValidator = tShape<UserSearchRequest>({
prefix: t.maybe(t.String), prefix: t.maybe(t.String),
}); });
export const userSearchResultValidator: TInterface<UserSearchResult> = export const userSearchResultValidator: TInterface<UserSearchResult> =
Show All 14 Lines): Promise<UserSearchResult> {
const result = { userInfos: searchResults }; const result = { userInfos: searchResults };
return validateOutput( return validateOutput(
viewer.platformDetails, viewer.platformDetails,
userSearchResultValidator, userSearchResultValidator,
result, result,
); );
} }
export { userSearchResponder }; const exactUserSearchRequestInputValidator = tShape<ExactUserSearchRequest>({
username: t.String,
});
const exactUserSearchResultValidator = tShape<ExactUserSearchResult>({
userInfo: t.maybe(globalAccountUserInfoValidator),
});
async function exactUserSearchResponder(
viewer: Viewer,
input: mixed,
): Promise<ExactUserSearchResult> {
const request = await validateInput(
viewer,
exactUserSearchRequestInputValidator,
input,
);
const searchResult = await searchForUser(request.username);
const result = { userInfo: searchResult };
return validateOutput(
viewer.platformDetails,
exactUserSearchResultValidator,
result,
);
}
export { userSearchResponder, exactUserSearchResponder };