Page MenuHomePhabricator
Differential D7569

[lib] Introduce raw thread info validators
ClosedPublic
Actions

Authored by michal on Apr 21 2023, 8:12 AM.
Tags
None
Referenced Files
F5928330: D7569.id26100.diff
Fri, Apr 18, 1:54 AM
F5924662: D7569.id25546.diff
Thu, Apr 17, 11:52 PM
F5884093: D7569.diff
Thu, Apr 17, 3:21 AM
Unknown Object (File)
Wed, Apr 9, 12:58 AM
Unknown Object (File)
Tue, Apr 8, 11:02 PM
Unknown Object (File)
Tue, Apr 8, 10:46 PM
Unknown Object (File)
Tue, Apr 8, 10:23 PM
Unknown Object (File)
Tue, Apr 8, 9:56 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
inka
tomek
Commits
rCOMMf0de5dc1e446: [lib] Introduce raw thread info validators
Summary

Adds validators for RawThreadInfo and nested types. The example thread info in tests is taken from the app but it's cut a bit so it's shorter.

Depends D7567

Test Plan

Run yarn jest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

michal created this revision.Apr 21 2023, 8:12 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 8:12 AM
michal updated this revision to Diff 25547.Apr 21 2023, 8:13 AM

Fix

michal added a child revision: D7571: [lib] Introduce raw entry info validators.Apr 21 2023, 8:15 AM
Harbormaster completed remote builds in B18655: Diff 25546.Apr 21 2023, 8:29 AM
Harbormaster completed remote builds in B18656: Diff 25547.
michal requested review of this revision.Apr 21 2023, 8:31 AM
michal added a parent revision: D7567: [lib] Introduce raw message info validators.Apr 25 2023, 6:21 AM
tomek accepted this revision.Apr 25 2023, 3:25 PM

Could we add a test where avatar is not defined (RawThreadInfo doesn't have this field at all, not just it is set to null or undefined).

lib/types/thread-types.js
265 ↗(On Diff #25547)

This prop is optional and nullable in RawThreadInfo but is described by tComb types as other props that are only nullable. Is there a way to describe it more precisely?

This revision is now accepted and ready to land.Apr 25 2023, 3:25 PM
michal added a comment.Apr 27 2023, 6:17 AM

Could we add a test where avatar is not defined (RawThreadInfo doesn't have this field at all, not just it is set to null or undefined).

The existing thread example already doesn't have avatar defined.

lib/types/thread-types.js
265 ↗(On Diff #25547)

We would have to add custom tComb validators for only-undefined-maybe and only-null-maybe. We already use t.maybe for fields that are both optional and nullable in a few places. If we add these validators it would probably make sense to also update existing validators.

michal added a parent revision: D7655: [lib] Add validator to the message spec.Apr 27 2023, 6:29 AM
ashoat added inline comments.Apr 27 2023, 12:37 PM
lib/types/thread-types.js
265 ↗(On Diff #25547)

Personally I think it's fine to leave as-is... I can't think of a security threat that this input validation would catch, and it won't help for the IDs migration either

michal updated this revision to Diff 26059.May 4 2023, 3:06 AM

Rebase

Harbormaster completed remote builds in B19028: Diff 26059.May 4 2023, 3:28 AM
michal updated this revision to Diff 26100.May 5 2023, 4:11 AM

Also convert roles

Harbormaster completed remote builds in B19066: Diff 26100.May 5 2023, 4:28 AM
Closed by commit rCOMMf0de5dc1e446: [lib] Introduce raw thread info validators (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM
This revision was automatically updated to reflect the committed changes.
Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMf0de5dc1e446: [lib] Introduce raw thread info validators.

Revision Contents
Changeset List

PathSize
lib/
types/
22 lines
7 lines
67 lines
314 lines

Diff 26111

View Options

lib/types/avatar-types.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/types/subscription-types.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/types/thread-types.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };
View Options

lib/types/validation.test.js

// @flow // @flow
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import type { PlatformDetails } from '../types/device-types';
import type { KeyserverInfo } from '../types/keyserver-types'; import type { KeyserverInfo } from '../types/keyserver-types';
import type { AppState } from '../types/redux-types.js'; import type { AppState } from '../types/redux-types.js';
import type { ConnectionInfo } from '../types/socket-types.js'; import type { ConnectionInfo } from '../types/socket-types.js';
import { ashoatKeyserverID } from '../utils/validation-utils.js'; import { ashoatKeyserverID } from '../utils/validation-utils.js';
const cookieSelector: (state: AppState) => ?string = (state: AppState) => const cookieSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.cookie;
Show All 24 Lines
const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) => const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix; state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;
const connectionSelector: (state: AppState) => ?ConnectionInfo = ( const connectionSelector: (state: AppState) => ?ConnectionInfo = (
state: AppState, state: AppState,
) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection; ) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;
const lastCommunicatedPlatformDetailsSelector: (
state: AppState,
) => ?PlatformDetails = (state: AppState) =>
state.keyserverStore.keyserverInfos[ashoatKeyserverID]
?.lastCommunicatedPlatformDetails;
export { export {
cookieSelector, cookieSelector,
cookiesSelector, cookiesSelector,
sessionIDSelector, sessionIDSelector,
updatesCurrentAsOfSelector, updatesCurrentAsOfSelector,
currentAsOfSelector, currentAsOfSelector,
urlPrefixSelector, urlPrefixSelector,
connectionSelector, connectionSelector,
lastCommunicatedPlatformDetailsSelector,
}; };