Adds validators for RawThreadInfo and nested types. The example thread info in tests is taken from the app but it's cut a bit so it's shorter.
Depends D7567
Details
Details
- Reviewers
kamil inka tomek - Commits
- rCOMMf0de5dc1e446: [lib] Introduce raw thread info validators
Run yarn jest
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Could we add a test where avatar is not defined (RawThreadInfo doesn't have this field at all, not just it is set to null or undefined).
| lib/types/thread-types.js | ||
|---|---|---|
| 265 | This prop is optional and nullable in RawThreadInfo but is described by tComb types as other props that are only nullable. Is there a way to describe it more precisely? | |
Comment Actions
Could we add a test where avatar is not defined (RawThreadInfo doesn't have this field at all, not just it is set to null or undefined).
The existing thread example already doesn't have avatar defined.
| lib/types/thread-types.js | ||
|---|---|---|
| 265 | We would have to add custom tComb validators for only-undefined-maybe and only-null-maybe. We already use t.maybe for fields that are both optional and nullable in a few places. If we add these validators it would probably make sense to also update existing validators. | |
| lib/types/thread-types.js | ||
|---|---|---|
| 265 | Personally I think it's fine to leave as-is... I can't think of a security threat that this input validation would catch, and it won't help for the IDs migration either | |