Paths

Table of Contentst

[lib] Move update type enum into a separate file
ClosedPublic
Actions

Authored by michal on May 11 2023, 2:16 AM.

Details

Reviewers

kamil
tomek
ashoat

Commits

rCOMMa78ac1d8d31a: [lib] Move update type enum into a separate file

Summary

Moved the enum to fix dependency cycles (that would be introduced in the later diffs).

Depends on D7785

Test Plan

Run yarn jest-all and yarn flow-all

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.May 11 2023, 2:16 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 11 2023, 2:16 AM

michal added a child revision: D7786: [web] Validate website responder.May 11 2023, 2:17 AM

Harbormaster completed remote builds in B19261: Diff 26363.May 11 2023, 2:34 AM

michal requested review of this revision.May 11 2023, 2:34 AM

ashoat accepted this revision.May 12 2023, 2:14 AM

This revision is now accepted and ready to land.May 12 2023, 2:14 AM

Closed by commit rCOMMa78ac1d8d31a: [lib] Move update type enum into a separate file (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMMa78ac1d8d31a: [lib] Move update type enum into a separate file.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

message-creator.js

2 lines

update-creator.js

2 lines

deleters/

account-deleters.js

2 lines

thread-deleters.js

2 lines

fetchers/

update-fetchers.js

7 lines

push/

send.js

2 lines

scripts/

merge-users.js

3 lines

rename-user.js

2 lines

setup-sidebars.js

2 lines

updaters/

account-updaters.js

2 lines

activity-updaters.js

2 lines

entry-updaters.js

6 lines

relationship-updaters.js

3 lines

thread-permission-updaters.js

2 lines

thread-updaters.js

2 lines

user-subscription-updaters.js

2 lines

lib/

reducers/

calendar-filters-reducer.js

2 lines

device-token-reducer.js

2 lines

2 lines

2 lines

2 lines

2 lines

6 lines

shared/

thread-utils.js

3 lines

update-utils.js

2 lines

types/

update-types-enum.js

31 lines

update-types.js

30 lines

validation.test.js

2 lines

Diff 26458

View Options

keyserver/src/creators/message-creator.js

View Options

keyserver/src/creators/update-creator.js

View Options

keyserver/src/deleters/account-deleters.js

View Options

keyserver/src/deleters/thread-deleters.js

View Options

keyserver/src/fetchers/update-fetchers.js

View Options

keyserver/src/push/send.js

View Options

keyserver/src/scripts/merge-users.js

View Options

keyserver/src/scripts/rename-user.js

View Options

keyserver/src/scripts/setup-sidebars.js

View Options

keyserver/src/updaters/account-updaters.js

View Options

keyserver/src/updaters/activity-updaters.js

View Options

keyserver/src/updaters/entry-updaters.js

View Options

keyserver/src/updaters/relationship-updaters.js

View Options

keyserver/src/updaters/thread-permission-updaters.js

View Options

keyserver/src/updaters/thread-updaters.js

View Options

keyserver/src/updaters/user-subscription-updaters.js

View Options

lib/reducers/calendar-filters-reducer.js

View Options

lib/reducers/device-token-reducer.js

View Options

lib/reducers/entry-reducer.js

View Options

lib/reducers/local-id-reducer.js

View Options

lib/reducers/message-reducer.js

View Options

lib/reducers/thread-reducer.js

View Options

lib/reducers/user-reducer.js

View Options

lib/shared/thread-utils.js

View Options

lib/shared/update-utils.js

View Options

lib/types/update-types-enum.js

View Options

lib/types/update-types.js

View Options

lib/types/validation.test.js

[lib] Move update type enum into a separate fileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26458

keyserver/src/creators/message-creator.js

keyserver/src/creators/update-creator.js

keyserver/src/deleters/account-deleters.js

keyserver/src/deleters/thread-deleters.js

keyserver/src/fetchers/update-fetchers.js

keyserver/src/push/send.js

keyserver/src/scripts/merge-users.js

keyserver/src/scripts/rename-user.js

keyserver/src/scripts/setup-sidebars.js

keyserver/src/updaters/account-updaters.js

keyserver/src/updaters/activity-updaters.js

keyserver/src/updaters/entry-updaters.js

keyserver/src/updaters/relationship-updaters.js

keyserver/src/updaters/thread-permission-updaters.js

keyserver/src/updaters/thread-updaters.js

keyserver/src/updaters/user-subscription-updaters.js

lib/reducers/calendar-filters-reducer.js

lib/reducers/device-token-reducer.js

lib/reducers/entry-reducer.js

lib/reducers/local-id-reducer.js

lib/reducers/message-reducer.js

lib/reducers/thread-reducer.js

lib/reducers/user-reducer.js

lib/shared/thread-utils.js

lib/shared/update-utils.js

lib/types/update-types-enum.js

lib/types/update-types.js

lib/types/validation.test.js

[lib] Move update type enum into a separate file
ClosedPublic
Actions

Revision Contents
Changeset List