Differential D7785 Authored by michal on May 10 2023, 5:16 PM.
Details
Summary Moves socket errors to errors.js to prevent cyclic dependencies. I don't we are using ExtendableError in any other place, so I think this move makes sense. Depends on D7783 Test Plan Run flow and jest, check if web and landing work.
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptMay 10 2023, 5:16 PM2023-05-10 17:16:10 (UTC+0) michal added a child revision: D7786: [web] Validate website responder.May 10 2023, 5:20 PM2023-05-10 17:20:51 (UTC+0) Harbormaster completed remote builds in B19257: Diff 26359.May 10 2023, 5:33 PM2023-05-10 17:33:34 (UTC+0) michal removed a child revision: D7786: [web] Validate website responder.May 11 2023, 9:17 AM2023-05-11 09:17:20 (UTC+0) michal added a child revision: D7786: [web] Validate website responder.May 11 2023, 9:18 AM2023-05-11 09:18:41 (UTC+0) This revision is now accepted and ready to land.May 12 2023, 9:13 AM2023-05-12 09:13:14 (UTC+0) Closed by commit rCOMM179dc8da526a: [lib] Move socket errors to errors.js. · Explain WhyMay 15 2023, 12:00 PM2023-05-15 12:00:21 (UTC+0) This revision was automatically updated to reflect the committed changes. Restricted Repository Identity added a commit: rCOMM179dc8da526a: [lib] Move socket errors to errors.js.
Revision Contents
Diff 26459 |