Moves socket errors to errors.js to prevent cyclic dependencies. I don't we are using ExtendableError in any other place, so I think this move makes sense.
Depends on D7783
Details
Details
- Reviewers
kamil tomek ashoat - Commits
- rCOMM179dc8da526a: [lib] Move socket errors to errors.js
Summary
Test Plan
Run flow and jest, check if web and landing work.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Herald added subscribers: atul, ashoat. · View Herald TranscriptMay 10 2023, 10:16 AM2023-05-10 10:16:10 (UTC-7)
michal added a child revision: D7786: [web] Validate website responder.May 10 2023, 10:20 AM2023-05-10 10:20:51 (UTC-7)
Harbormaster completed remote builds in B19257: Diff 26359.May 10 2023, 10:33 AM2023-05-10 10:33:34 (UTC-7)
michal removed a child revision: D7786: [web] Validate website responder.May 11 2023, 2:17 AM2023-05-11 02:17:20 (UTC-7)
michal added a child revision: D7786: [web] Validate website responder.May 11 2023, 2:18 AM2023-05-11 02:18:41 (UTC-7)
This revision is now accepted and ready to land.May 12 2023, 2:13 AM2023-05-12 02:13:14 (UTC-7)
Closed by commit rCOMM179dc8da526a: [lib] Move socket errors to errors.js (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 15 2023, 5:00 AM2023-05-15 05:00:21 (UTC-7)
This revision was automatically updated to reflect the committed changes.