Add validators for RawMessageInfo and inner types and tests for each message type. In tests all message examples are taken from the app except for change role, unsupported, edit message and pin message which I wrote manually.
Depends on D7566
Differential D7567 Authored by michal on Apr 21 2023, 8:08 AM.
Tags None Referenced Files
Details
Summary Add validators for RawMessageInfo and inner types and tests for each message type. In tests all message examples are taken from the app except for change role, unsupported, edit message and pin message which I wrote manually. Depends on D7566 Test Plan Run yarn jest
Diff Detail
Event TimelineHerald added subscribers: atul, ashoat. · View Herald TranscriptApr 21 2023, 8:08 AM2023-04-21 08:08:34 (UTC-7) Harbormaster completed remote builds in B18653: Diff 25544.Apr 21 2023, 8:25 AM2023-04-21 08:25:24 (UTC-7) michal added a child revision: D7569: [lib] Introduce raw thread info validators.Apr 25 2023, 6:21 AM2023-04-25 06:21:32 (UTC-7) tomek added inline comments. This revision is now accepted and ready to land.Apr 25 2023, 7:30 AM2023-04-25 07:30:20 (UTC-7) michal added a child revision: D7655: [lib] Add validator to the message spec.Apr 27 2023, 6:29 AM2023-04-27 06:29:37 (UTC-7) Harbormaster completed remote builds in B18854: Diff 25823.Apr 27 2023, 6:45 AM2023-04-27 06:45:10 (UTC-7) Harbormaster completed remote builds in B19026: Diff 26057.May 4 2023, 3:25 AM2023-05-04 03:25:48 (UTC-7) Harbormaster completed remote builds in B19065: Diff 26099.May 5 2023, 4:23 AM2023-05-05 04:23:45 (UTC-7) Closed by commit rCOMM8a48d2c36145: [lib] Introduce raw message info validators (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyMay 5 2023, 5:46 AM2023-05-05 05:46:29 (UTC-7) This revision was automatically updated to reflect the committed changes. Michal Gniadek <michal.gniadek@swmansion.com> mentioned this in rCOMMce72e5f71c1f: [lib] Add validator to the message spec.
Revision Contents
Diff 26099 |