Page MenuHomePhabricator

[lib] Allow calling link-disabling endpoint
ClosedPublic

Authored by tomek on May 22 2023, 6:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 19 2024, 5:43 PM
Unknown Object (File)
Feb 19 2024, 4:40 PM
Unknown Object (File)
Feb 19 2024, 2:03 PM
Unknown Object (File)
Feb 19 2024, 12:45 PM
Unknown Object (File)
Feb 19 2024, 6:04 AM
Unknown Object (File)
Jan 1 2024, 1:56 AM
Unknown Object (File)
Dec 16 2023, 3:54 AM
Unknown Object (File)
Dec 16 2023, 12:05 AM
Subscribers

Details

Summary

The reducer deletes an entry in the store. In the future we will have to do more here, as not only public links can be disabled.

Depends on D7906

Test Plan

Confirm disabling a link and check if it was deleted, e.g. by verifying that disable link button disappears.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.May 22 2023, 6:47 AM

I think the differential name is not complete and confusing a bit

lib/reducers/invite-links-reducer.js
44

I would move currentPrimaryLink?.name === action.payload.name condition to if upper, and avoid modifying the state if it's falsy

This revision is now accepted and ready to land.May 22 2023, 10:44 AM
In D7907#234718, @kamil wrote:

I think the differential name is not complete and confusing a bit

It seems so... not sure what happened

tomek retitled this revision from [lib] Add reducer and endpoint calling code to [lib] Allow calling link-disabling endpoint.May 23 2023, 6:52 AM

Make reducer more efficient

This revision was automatically updated to reflect the committed changes.