In D14444#401312, @ashoat wrote:

Does it not occur on every single login because the NUX doesn't display on subsequent logins?

Does it not occur on every single login because the NUX doesn't display on subsequent logins?

Alternately, does this occur for every fresh install login?

Feels like there are probably ways to dismiss the modal without setting the fid to null here. Ideally we can catch all methods of closing the modal, but if that's really hard, one alternative would just be to set the fid to null as soon as we show the modal.

Ended up testing the connect farcaster flow and it works. A couple things worth noting:

1. The connect farcaster bottom sheet appears at the same time as the NUX tips if the user installs the app and logs in. Not sure if this edge case is worth addressing

some updates

need to think about how to sequence things a little more

Emscripten failure is weird, not sure why that's happening, but definitely unrelated to this diff (perhaps the issue is live on master). Created ENG-10380 to investigate

avoid button height change

The button height changes a bit after it enters the loading state.

CI

Rebase

Rebase & fix outsideButtons on Android

Rebase

Tested this on a physical device and emulator, everything seems to be fine

In D14434#401075, @ashoat wrote:

CI - not sure if I need to test something else; not familiar with Android configuration

I think it would be good to check the Android app for both emulator and physical device targets, and play around with it a little bit just to make sure nothing is broken and performance isn't degraded

CI - not sure if I need to test something else; not familiar with Android configuration

One thing that might be worth checking is whether the outsideButtons logic is still correct

In D14430#401022, @tomek wrote:

How does the app look like with a modal and the status bar visible?

How does the app look like with a modal and the status bar visible?

Wrap in ignorePromiseRejections

CI

CI