Page MenuHomePhabricator

Active Repositories

Recent Activity

Today

ashoat accepted D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Tue, Jan 7, 3:38 PM
varun updated the diff for D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.

return communities that the member is a part of

Tue, Jan 7, 3:36 PM
ashoat added inline comments to D14184: [lib] Add timeout to useWaitForConnection() hook.
Tue, Jan 7, 9:22 AM
ashoat committed rCOMM3932e8c510c5: [lib] Fix SIWESignatureRequestData union type (authored by ashoat).
[lib] Fix SIWESignatureRequestData union type
Tue, Jan 7, 9:21 AM
ashoat added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Tue, Jan 7, 9:18 AM
bartek accepted D14180: [native] Fall back to v1 login when the user doesn't have a backup.

Because pf https://linear.app/comm/issue/ENG-10039/allow-checking-if-a-user-has-a-backup I had to hack it a bit: instead of calling retrieveLatestBackupInfo I hardcoded its return value to null. Then for both password and SIWE user verified that it is possible to log in.

Tue, Jan 7, 7:20 AM
bartek closed D14178: [terraform] Bump staging Identity to 0.48.
Tue, Jan 7, 7:17 AM
bartek committed rCOMMc9dcc62c9557: [terraform] Bump staging Identity to 0.48 (authored by bartek).
[terraform] Bump staging Identity to 0.48
Tue, Jan 7, 7:17 AM
bartek closed D14177: [terraform] Bump prod Identity to 0.47.
Tue, Jan 7, 7:17 AM
bartek committed rCOMM5b11e1ba47d9: [terraform] Bump prod Identity to 0.47 (authored by bartek).
[terraform] Bump prod Identity to 0.47
Tue, Jan 7, 7:17 AM
kamil accepted D14183: [native] Read native credentials during restore flow.
Tue, Jan 7, 6:57 AM
kamil accepted D14182: [native] Update device list as a part of the restoration.
Tue, Jan 7, 6:52 AM
kamil accepted D14180: [native] Fall back to v1 login when the user doesn't have a backup.
Tue, Jan 7, 6:49 AM
angelika requested review of D14184: [lib] Add timeout to useWaitForConnection() hook.
Tue, Jan 7, 6:04 AM
angelika added a comment to D14167: [lib] Wait for tunnelbroker and keyserver connection when updating relationships.

Are we sure we want to wait for the connection in each place where useUpdateRelationships is used? There are a lot of them.

We don’t wait every time we call useUpdateRelationships, the waiting is put in updateRelationshipsAndSendRobotext, so it waits only when we create a new relationship.

Should we wait again after e.g. Tunnelbroker gets disconnected, or should we just wait for the initial connection?

I think it's better to wait again:

  1. The bugs will happen mostly when we’re opening the app but I think it’s theoretically possible for the bug to appear after tunnelbroker is disconnected
  2. It’s easier

Do we want to have a timeout?

We can have a timeout but what do we do if we encounter it?

  • Ignore everything and let the duplicated thread be created?
  • Throw an error?

I think throwing an error is better so I added it for now in a separate diff.

What if the waitForConnection function was called multiple times? We're resolving only the most recent promise because creating a new one results in overriding the ref.

Ok, I guess it may be possible for this scenario to occur, I added a list of promises.

Is it guaranteed that if waitForConnection is called when isConnectedOrUnreachable is false, and then turns to true, the effect will always fire late enough so that the ref already contains the resolve function?

I don’t understand what can be problematic here. When waitForConnection is called we check for isConnectedOrUnreachable. If it’s false then we set the callback to the ref and return the promise. There is nothing async and no waiting on anything and useEffect can’t fire during setting the callback because js is one threaded.

Tue, Jan 7, 5:46 AM
angelika updated the diff for D14167: [lib] Wait for tunnelbroker and keyserver connection when updating relationships.

Review changes: add list of promises

Tue, Jan 7, 5:41 AM
tomek requested review of D14183: [native] Read native credentials during restore flow.
Tue, Jan 7, 3:04 AM
tomek requested review of D14182: [native] Update device list as a part of the restoration.
Tue, Jan 7, 1:39 AM

Yesterday

bartek added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Mon, Jan 6, 11:57 PM
bartek added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Mon, Jan 6, 11:54 PM

Wed, Dec 25

ashoat added inline comments to D14180: [native] Fall back to v1 login when the user doesn't have a backup.
Wed, Dec 25, 8:46 AM
ashoat added inline comments to D14179: [lib] Refactor useLogOut to auto-detect logout flow.
Wed, Dec 25, 8:45 AM
ashoat committed rCOMM113111f95d0d: [lib] Remove "a" from "Retrieve a backup key" (authored by ashoat).
[lib] Remove "a" from "Retrieve a backup key"
Wed, Dec 25, 8:44 AM
ashoat accepted D14178: [terraform] Bump staging Identity to 0.48.
Wed, Dec 25, 8:44 AM
ashoat accepted D14177: [terraform] Bump prod Identity to 0.47.
Wed, Dec 25, 8:43 AM

Tue, Dec 24

ashoat committed rCOMMeb31a84bb78a: [landing] Remove Will from team list (authored by ashoat).
[landing] Remove Will from team list
Tue, Dec 24, 11:53 AM
ashoat accepted D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Tue, Dec 24, 10:18 AM

Mon, Dec 23

varun updated the summary of D14181: [keyserver] filter out communities that viewer is a member of or that aren't public.
Mon, Dec 23, 9:18 PM
varun published D14181: [keyserver] filter out communities that viewer is a member of or that aren't public for review.
Mon, Dec 23, 9:17 PM
ashoat added inline comments to D13994: [native] community list item component.
Mon, Dec 23, 8:20 AM
ashoat accepted D13994: [native] community list item component.
Mon, Dec 23, 8:19 AM
varun attached a referenced file: F3522827: Simulator Screen Recording - iPhone 16 Pro - 2024-12-23 at 10.28.45.mp4.
Mon, Dec 23, 7:37 AM
varun added a comment to D13994: [native] community list item component.

Mon, Dec 23, 7:37 AM
varun updated the diff for D13994: [native] community list item component.

address feedback

Mon, Dec 23, 7:36 AM

Sat, Dec 21

ashoat committed rCOMMde65669e2e44: [terraform] Bump keyserver image to 1.0.149 (authored by ashoat).
[terraform] Bump keyserver image to 1.0.149
Sat, Dec 21, 12:10 PM
ashoat committed rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release" (authored by ashoat).
Revert "[native] Temporary changes for staff release"
Sat, Dec 21, 9:45 AM
ashoat added a reverting change for rCOMMec8443e9e70d: [native] Temporary changes for staff release: rCOMMcd2b9afc1ccc: Revert "[native] Temporary changes for staff release".
Sat, Dec 21, 9:45 AM
ashoat committed rCOMM725f61f3d048: [native] codeVersion -> 454 (authored by ashoat).
[native] codeVersion -> 454
Sat, Dec 21, 9:45 AM
ashoat committed rCOMMec8443e9e70d: [native] Temporary changes for staff release (authored by ashoat).
[native] Temporary changes for staff release
Sat, Dec 21, 9:45 AM
ashoat committed rCOMM61284c683669: [native] codeVersion -> 453 (authored by ashoat).
[native] codeVersion -> 453
Sat, Dec 21, 9:45 AM