User Details
User Details
- User Since
- Dec 29 2020, 8:08 PM (181 w, 1 d)
- Roles
- Administrator
Yesterday
Yesterday
atul requested review of D12472: [lib] Fix construction of `RawThreadInfo` in `createPendingThread`.
Tue, Jun 18
Tue, Jun 18
atul requested review of D12470: [lib] Remove `member.permissions` from `RawThreadInfo` test data.
atul committed rCOMMb6356f154af9: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers` (authored by atul).
[lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`
atul updated the diff for D12321: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`.
land
Mon, Jun 17
Mon, Jun 17
[lib] Introduce `MemberInfoSansPermissions`
atul updated the diff for D12315: [lib] Introduce `MemberInfoSansPermissions`.
use $Diff
atul updated the diff for D12315: [lib] Introduce `MemberInfoSansPermissions`.
rebase before landing
atul committed rCOMMbcd2ea0419e5: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions` (authored by atul).
[lib] Rename `MemberInfo` to `MemberInfoWithPermissions`
atul updated the diff for D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
land
atul updated the diff for D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
amend
atul committed rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of… (authored by atul).
[lib] Pull `baseThreadIsWithBlockedUserOnly` out of…
atul updated the diff for D12295: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`.
land
atul committed rCOMM67a5bdca2dc0: [lib] Remove `skipMemberAdminRoleCheck` option from… (authored by atul).
[lib] Remove `skipMemberAdminRoleCheck` option from…
atul updated the diff for D12294: [lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`.
land
Sun, Jun 16
Sun, Jun 16
atul committed rCOMM0050bc8a8abe: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock` (authored by atul).
[lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`
atul updated the diff for D12293: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock`.
land
atul committed rCOMM509ef589a60d: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant` (authored by atul).
[lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant`
atul updated the diff for D12292: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant`.
rebase and land
atul updated the test plan for D12292: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant`.
atul committed rCOMM940b2ff9147f: [lib] Replace `innerThreadFrozenDueToBlock` with… (authored by atul).
[lib] Replace `innerThreadFrozenDueToBlock` with…
atul updated the diff for D12290: [lib] Replace `innerThreadFrozenDueToBlock` with `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` in `useThreadsWithPermission`.
rebase and land
atul committed rCOMM727b3b565aa0: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` (authored by atul).
[lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`
atul updated the test plan for D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`.
atul updated the diff for D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`.
rebase before landing
atul committed rCOMM8841136a2935: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar` (authored by atul).
[lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`
atul added inline comments to D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`.
atul updated the test plan for D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`.
atul updated the diff for D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`.
remove communityThreadInfo and userInfos props
atul updated the diff for D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar`.
rebase before addressing feedback + landing
atul committed rCOMMd6fa6b7fc944: [lib] Introduce `useThreadFrozenDueToViewersBlock` (authored by atul).
[lib] Introduce `useThreadFrozenDueToViewersBlock`
atul updated the test plan for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
atul updated the diff for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
land
atul added inline comments to D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
atul updated the diff for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
get rid of unneeded memoization
Sat, Jun 15
Sat, Jun 15
atul committed rCOMM56ba0de13be0: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions` (authored by atul).
[lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`
atul added a comment to D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
NOTE TO SELF: Make sure that changes to validators in this stack (or higher level validators which consume them) do not break anything for older clients, etc.
atul updated the diff for D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
remove relativeMemberInfoValidator export
atul updated the diff for D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
address feedback (remove $ReadOnly wrapper)
Wed, Jun 12
Wed, Jun 12
atul updated the diff for D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
rebase BEFORE addressing feedback and landing
[lib] Remove `getCurrentUser`
Tue, Jun 11
Tue, Jun 11
atul updated the diff for D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`.
resolve merge conflict
atul added inline comments to D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
atul updated the diff for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
fix useCommunityRootMembersToRole logic
atul updated the diff for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
remove now extraneous communityThreadInfo and userInfos props in native/ChatInputBar
atul added inline comments to D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
atul updated the diff for D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
Add memoization to useThreadFrozenDueToViewerBlock
atul committed rCOMM92a8efadedbf: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo` (authored by atul).
[lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`
atul updated the diff for D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
actualyl land
atul requested review of D12158: [lib] Remove `getCurrentUser`.
- Can you share where you're tracking all permissions checks on the client (ideally on Linear), so I can confirm that they're all updated to use hooks that check block status?
atul requested review of D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
Agree we can do better than the invariant.
atul retitled D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions` from [DRAFT][lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions` to [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
atul updated the diff for D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
land
atul updated the diff for D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
strip out comments before landing
atul attached a referenced file: F1993792: a1d55b.png.
atul attached a referenced file: F1993795: 965b58.png.
atul added inline comments to D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
Wed, Jun 5
Wed, Jun 5
atul published D12321: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers` for review.
Tue, Jun 4
Tue, Jun 4
atul published D12315: [lib] Introduce `MemberInfoSansPermissions` for review.
atul added a comment to D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
atul added a comment to D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
Safe to land in isolation since it's a simple rename.
atul updated the diff for D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
cherry-pick
atul planned changes to D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
Local commit includes memoization/pruning of props. Will do a rebase and update this diff.
Mon, Jun 3
Mon, Jun 3
atul published D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions` for review.
atul added inline comments to D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock`.
atul added inline comments to D12265: [lib] Remove `permissions` field from `ThreadInfo.members[memberID].permissions`.
atul published D12293: [lib] Inline `innerThreadFrozenDueToBlock` in `threadFrozenDueToBlock` for review.
atul published D12292: [lib] Narrow types in `memberHasAdminPowers` call stack to remove `invariant` for review.
atul published D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck` for review.
atul published D12288: [lib] Consume `useThreadFrozenDueToViewerBlock` in `web/ChatInputBar` for review.
atul published D12287: [lib] Introduce `useThreadFrozenDueToViewersBlock` for review.
atul committed rCOMMc2da721a842f: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock` (authored by atul).
[lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`
atul updated the diff for D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
rebase and land
Sat, Jun 1
Sat, Jun 1
atul requested review of D12266: [lib] Narrow `threadInfo` argument of `threadFrozenDueToViewerBlock`.
Fri, May 31
Fri, May 31
atul requested review of D12259: [lib] Replace `threadMemberHasPermission` logic in `appendUserInfo`.
atul committed rCOMM3e1eaaa86882: [lib] Fix `containingThreadID` typo in `usePotentialMemberItems` (authored by atul).
[lib] Fix `containingThreadID` typo in `usePotentialMemberItems`