Paths

Table of Contentst

-
lib/shared/
-
shared/
-
thread-utils.js

Differential D10159

[lib] Get rid of switchMemberAdminRoleInThread
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 19, 1:32 AM

	Unknown Object (File)
	Fri, Apr 18, 11:21 PM

	Unknown Object (File)
	Fri, Apr 18, 10:35 PM

	Unknown Object (File)
	Fri, Apr 18, 9:00 AM

	Unknown Object (File)
	Sat, Apr 12, 7:05 PM

	Unknown Object (File)
	Wed, Apr 9, 12:47 AM

	Unknown Object (File)
	Tue, Apr 8, 8:33 PM

	Unknown Object (File)
	Tue, Apr 1, 12:12 PM

View All 83 Files

Subscribers

Details

Reviewers

Commits

rCOMM30126e729887: [lib] Get rid of switchMemberAdminRoleInThread

Summary

Working on enabling the unused-promise Flow lint (ENG-5907), and this got flagged because of the dispatchActionPromise usage.

I looked but I couldn't see any usages of this function in the codebase. I think the last usage was removed in D8155.

Depends on D10158

Test Plan

Flow

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:08 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:08 PM

ashoat added a child revision: D10160: [lib] Don't return a promise from ignorePromiseRejections.Dec 4 2023, 1:09 PM

Harbormaster completed remote builds in B24738: Diff 34201.Dec 4 2023, 1:39 PM

ashoat requested review of this revision.Dec 4 2023, 1:39 PM

rohan accepted this revision.Dec 4 2023, 7:26 PM

This revision is now accepted and ready to land.Dec 4 2023, 7:26 PM

Closed by commit rCOMM30126e729887: [lib] Get rid of switchMemberAdminRoleInThread (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM30126e729887: [lib] Get rid of switchMemberAdminRoleInThread.

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

34 lines

Diff 34201

lib/shared/thread-utils.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};