Page MenuHomePhabricator
Differential D10206

[keyserver] Set a job that synchronizes links with blobs
ClosedPublic
Actions

Authored by tomek on Dec 6 2023, 6:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 12, 5:05 PM
Unknown Object (File)
Sat, May 11, 8:06 PM
Unknown Object (File)
Mar 6 2024, 9:39 AM
Unknown Object (File)
Mar 6 2024, 9:39 AM
Unknown Object (File)
Mar 6 2024, 9:39 AM
Unknown Object (File)
Mar 6 2024, 9:39 AM
Unknown Object (File)
Mar 6 2024, 9:39 AM
Unknown Object (File)
Mar 6 2024, 9:39 AM
View All 18 Files
Subscribers
ashoat

Details

Reviewers
michal
bartek
rohan
Commits
rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs
Summary

Run this script daily. It should happen after Blob service cleanup, which starts between midnight and 0:15 AM and currently takes up to a couple of minutes.

Depends on D10205

Test Plan

Modify the schedule and check if the script runs.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Dec 6 2023, 6:39 AM
Herald added a subscriber: ashoat. · View Herald TranscriptDec 6 2023, 6:39 AM
tomek updated this revision to Diff 34339.Dec 6 2023, 6:44 AM

Fix

Harbormaster completed remote builds in B24823: Diff 34337.Dec 6 2023, 6:58 AM
Harbormaster completed remote builds in B24825: Diff 34339.Dec 6 2023, 7:17 AM
tomek requested review of this revision.Dec 6 2023, 7:17 AM
ashoat added inline comments.Dec 6 2023, 7:50 AM
keyserver/src/cron/cron.js
131 ↗(On Diff #34339)

I had interpreted your previous request as wanting to include "in the keyserver's timezone" here, but seeing this I wonder if you are fine omitting it. Either way, I think we should be consistent

rohan accepted this revision.Dec 7 2023, 9:54 AM

Looks good, I agree on having the comments consistent though

This revision is now accepted and ready to land.Dec 7 2023, 9:54 AM
tomek added a child revision: D10290: [lib] Modify link verification to call the proper keyserver.Dec 11 2023, 6:39 AM
tomek updated this revision to Diff 36526.Feb 1 2024, 7:20 AM
tomek marked an inline comment as done.

Update comment

Harbormaster failed remote builds in B26416: Diff 36526!Feb 1 2024, 7:36 AM
Harbormaster completed remote builds in B26416: Diff 36526.Feb 1 2024, 7:51 AM
tomek mentioned this in D11076: [keyserver] Create invite link blobs in a migration.Feb 14 2024, 7:05 AM
Closed by commit rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs (authored by tomek). · Explain WhyFeb 14 2024, 7:58 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM122195947a95: [keyserver] Set a job that synchronizes links with blobs.
tomek mentioned this in rCOMMa8b3efff9b29: [keyserver] Create invite link blobs in a migration.

Revision Contents
Changeset List

PathSize
keyserver/
src/
cron/
14 lines

Diff 36526

View Options

keyserver/src/cron/cron.js

Loading...