Paths

Table of Contentst

Differential D10542

[RN72][skip-ci] Automatic deletion of all unused ESLint disable directives
ClosedPublic
Actions

Authored by ashoat on Jan 4 2024, 12:38 PM.

Tags

None

Referenced Files

	F3401440: D10542.diff
	Mon, Dec 2, 12:08 PM

	Unknown Object (File)
	Thu, Nov 14, 8:33 PM

	Unknown Object (File)
	Thu, Nov 7, 8:15 AM

	Unknown Object (File)
	Oct 31 2024, 5:22 AM

	Unknown Object (File)
	Oct 31 2024, 5:22 AM

	Unknown Object (File)
	Oct 3 2024, 1:24 PM

	Unknown Object (File)
	Oct 3 2024, 1:24 PM

	Unknown Object (File)
	Oct 3 2024, 1:24 PM

View All 57 Files

Subscribers

Details

Reviewers

Commits

rCOMM496cf58fab30: [RN72][skip-ci] Automatic deletion of all unused ESLint disable directives

Summary

As of ESLint 8, unused disable directives can be automatically fixed. In the next diff we'll introduce --report-unused-disable-directives to our ESLint invocations. I'm removing the unused ESLint disable directives in this diff (prior to the introduction of --report-unused-disable-directives) to avoid unnecessary CI failures.

Depends on D10541

Test Plan

In combination with the next diff, run yarn eslint:fix from the repo root

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 4 2024, 12:38 PM

Herald added a subscriber: tomek. · View Herald TranscriptJan 4 2024, 12:38 PM

ashoat added a child revision: D10543: [RN72][skip-ci] Introduce --report-unused-disable-directives to ESLint invocations.Jan 4 2024, 12:39 PM

Harbormaster completed remote builds in B25498: Diff 35215.Jan 4 2024, 12:40 PM

ashoat requested review of this revision.Jan 4 2024, 12:40 PM

Remove unnecessarily inserted newlines

Harbormaster completed remote builds in B25501: Diff 35218.Jan 4 2024, 12:46 PM

Looks good

As an aside, noticed the following CI jobs were still running with [skip-ci]:

Went ahead and updated those Herald rules so they should be skipped going forward.

This revision is now accepted and ready to land.Jan 4 2024, 2:39 PM

Closed by commit rCOMM496cf58fab30: [RN72][skip-ci] Automatic deletion of all unused ESLint disable directives (authored by ashoat). · Explain WhyJan 4 2024, 6:12 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM496cf58fab30: [RN72][skip-ci] Automatic deletion of all unused ESLint disable directives.

ashoat mentioned this in D11048: [lib][web] Bring back eslint-disable-next-line for keyserver relative import in Webpack config.Feb 12 2024, 9:50 PM

Revision Contents
Changeset List

Path

Size

keyserver/

1 line

lib/

webpack/

1 line

native/

account/

logged-out-modal.react.js

2 lines

register-panel.react.js

2 lines

registration/

registration-terms.react.js

2 lines

chat/

chat-input-bar.react.js

2 lines

chat-thread-list-search.react.js

4 lines

11 lines

compose-subchannel.react.js

1 line

inner-robotext-message.react.js

4 lines

inner-text-message.react.js

2 lines

multimedia-message-multimedia.react.js

2 lines

multimedia-message-tooltip-button.react.js

2 lines

reaction-selection-popover.react.js

2 lines

robotext-message-tooltip-button.react.js

2 lines

text-message-tooltip-button.react.js

2 lines

2 lines

community-creation/

community-configuration.react.js

1 line

community-creation-members.react.js

1 line

components/

full-screen-view-modal.react.js

2 lines

gesture-touchable-opacity.react.js

2 lines

markdown/

12 lines

media/

camera-modal.react.js

2 lines

media-gallery-media.react.js

6 lines

video-playback-modal.react.js

1 line

navigation/

overlay-navigator.react.js

2 lines

tab-bar.react.js

4 lines

tab-navigator.react.js

4 lines

profile/

add-keyserver.react.js

1 line

profile.react.js

2 lines

relationship-list.react.js

1 line

redux/

2 lines

roles/

change-roles-screen.react.js

1 line

create-roles-screen.react.js

1 line

roles-navigator.react.js

1 line

tooltip/

tooltip.react.js

2 lines

utils/

animation-utils.js

2 lines

web/

chat/

robotext-message.react.js

4 lines

markdown/

5 lines

router-history.js

1 line

webpack.config.cjs

1 line

Diff 35218

keyserver/jest-setup.js

Loading...

lib/webpack/shared.cjs

Loading...

native/account/logged-out-modal.react.js

Loading...

native/account/register-panel.react.js

Loading...

native/account/registration/registration-terms.react.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

native/chat/chat-thread-list-search.react.js

Loading...

native/chat/chat.react.js

Loading...

native/chat/compose-subchannel.react.js

Loading...

native/chat/inner-robotext-message.react.js

Loading...

native/chat/inner-text-message.react.js

Loading...

native/chat/multimedia-message-multimedia.react.js

Loading...

native/chat/multimedia-message-tooltip-button.react.js

Loading...

native/chat/reaction-selection-popover.react.js

Loading...

native/chat/robotext-message-tooltip-button.react.js

Loading...

native/chat/text-message-tooltip-button.react.js

Loading...

native/chat/utils.js

Loading...

native/community-creation/community-configuration.react.js

Loading...

native/community-creation/community-creation-members.react.js

Loading...

native/components/full-screen-view-modal.react.js

Loading...

native/components/gesture-touchable-opacity.react.js

Loading...

native/markdown/rules.react.js

Loading...

native/media/camera-modal.react.js

Loading...

native/media/media-gallery-media.react.js

Loading...

native/media/video-playback-modal.react.js

Loading...

native/navigation/overlay-navigator.react.js

Loading...

native/navigation/tab-bar.react.js

Loading...

native/navigation/tab-navigator.react.js

Loading...

native/profile/add-keyserver.react.js

Loading...

native/profile/profile.react.js

Loading...

native/profile/relationship-list.react.js

Loading...

native/redux/persist.js

Loading...

native/roles/change-roles-screen.react.js

Loading...

native/roles/create-roles-screen.react.js

Loading...

native/roles/roles-navigator.react.js

Loading...

native/tooltip/tooltip.react.js

Loading...

native/utils/animation-utils.js

Loading...

web/chat/robotext-message.react.js

Loading...

web/markdown/rules.react.js

Loading...

web/router-history.js

Loading...

web/webpack.config.cjs

Loading...