[identity] Remove social proof from devices table
ClosedPublic
Actions

Authored by bartek on Jan 22 2024, 3:08 AM.

Details

Reviewers

varun
will
michal

Commits

rCOMMe0a66e14acea: [identity] Remove social proof from devices table

Summary

Part 2 of ENG-6480.
Since the social proof is stored in the users table, we don't need to store it in the devices table.

Depends on D10764

Test Plan

Repeated test plan from D10764. Verified that the social proof is still retrieved correctly, especially in GetKeyserverKeys RPC (for which I changed the code).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jan 22 2024, 3:08 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:08 AM

Harbormaster completed remote builds in B25988: Diff 35920.Jan 22 2024, 3:35 AM

bartek published this revision for review.Jan 22 2024, 3:52 AM

bartek added inline comments.

services/identity/src/database/device_list.rs
259–261 ↗	(On Diff #35920)	We agreed that we don't need social proof in `IdentityKeyInfo` returned from the GetXboundKeys RPCs so this field is going to be removed when we update the proto