Page MenuHomePhabricator
Differential D11176

[lib] Add keyserverID param to getClientResponsesSelector
ClosedPublic
Actions

Authored by tomek on Feb 26 2024, 6:37 AM.
Tags
None
Referenced Files
F2138701: D11176.diff
Fri, Jun 28, 11:51 PM
Unknown Object (File)
Thu, Jun 27, 2:04 AM
Unknown Object (File)
Wed, Jun 26, 9:32 PM
Unknown Object (File)
Tue, Jun 25, 6:55 PM
Unknown Object (File)
Fri, Jun 7, 7:17 PM
Unknown Object (File)
Fri, Jun 7, 7:17 PM
Unknown Object (File)
Fri, Jun 7, 7:16 PM
Unknown Object (File)
Fri, Jun 7, 3:11 PM
View All 23 Files
Subscribers
ashoat

Details

Reviewers
michal
atul
inka
kamil
Commits
rCOMMc34612666172: [lib] Add keyserverID param to getClientResponsesSelector
Summary

The selector needs to be aware of the keyserver that sent a message to prepare the correct response.

https://linear.app/comm/issue/ENG-6522/provide-a-keyserver-id-to-getclientresponsesselector-function

Depends on D11144

Test Plan

Console logged the value of keyserverID in getClientResponsesSelector on both web and native

Diff Detail

Repository
rCOMM Comm
Branch
sockets
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
selectors/
4 lines
native/
selectors/
7 lines
1 line
web/
selectors/
3 lines
1 line

Diff 37610

View Options

lib/selectors/socket-selectors.js

Loading...
View Options

native/selectors/socket-selectors.js

Loading...
View Options

native/socket.react.js

Loading...
View Options

web/selectors/socket-selectors.js

Loading...
View Options

web/socket.react.js

Loading...